RuntimeError in _groupcompress_pyx _expand_sources: "Conversion error : if we move self._source_infos"

[Adrian Wilkins]

Upgrading a rich-root-pack pull of the jtidy sourceforge SVN trunk, got the following stack trace

H:\src\test\jtidy>bzr upgrade
Upgrading branch file:///H:/src/test/jtidy/ ...
starting upgrade of file:///H:/src/test/jtidy/
making backup of file:///H:/src/test/jtidy/.bzr
  to file:///H:/src/test/jtidy/backup.bzr.~1~
starting repository conversion
conversion error: if we move self._source_infos, then we need to change all of the index pointers as well.
bzr: ERROR: exceptions.RuntimeError: if we move self._source_infos, then we need to change all of the index pointers as
well.

Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 926, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1126, in run_bzr
  File "bzrlib\commands.pyo", line 691, in run_argv_aliases
  File "bzrlib\commands.pyo", line 713, in run
  File "bzrlib\cleanup.pyo", line 135, in run_simple
  File "bzrlib\cleanup.pyo", line 165, in _do_with_cleanups
  File "bzrlib\builtins.pyo", line 3384, in run
RuntimeError: if we move self._source_infos, then we need to change all of the index pointers as well.

bzr 2.3.1 on python 2.6.6 (Windows-Vista-6.0.6002-SP2)
arguments: ['bzr', 'upgrade']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.3.1]
  colo C:\Program Files\Bazaar\plugins\colo [0.2.1]
  explorer C:\Program Files\Bazaar\plugins\explorer [1.1.2]
  fastimport C:\Program Files\Bazaar\plugins\fastimport [0.10.0]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [2.3.1]
  loom C:\Program Files\Bazaar\plugins\loom [2.2.1dev]
  netrc_credential_store C:\Program Files\Bazaar\plugins\netrc_credential_store [2.3.1]
  news_merge C:\Program Files\Bazaar\plugins\news_merge [2.3.1]
  pipeline C:\Program Files\Bazaar\plugins\pipeline [1.1.0]
  qbzr C:\Program Files\Bazaar\plugins\qbzr [0.20.0]
  rewrite C:\Program Files\Bazaar\plugins\rewrite [0.6.2dev]
  svn C:\Program Files\Bazaar\plugins\svn [1.0.5dev]
  upload C:\Program Files\Bazaar\plugins\upload [1.0.0]
  xmloutput C:\Program Files\Bazaar\plugins\xmloutput [0.8.7.dev]

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    including this traceback and a description of the problem.

H:\src\test\jtidy>

[Martin Pool (mbp)]

It looks like this is coming from groupcompress_pyx:

    cdef _expand_sources(self):
        raise RuntimeError('if we move self._source_infos, then we need to'
                           ' change all of the index pointers as well.')
        self._max_num_sources = self._max_num_sources * 2
        self._source_infos = <source_info *>safe_realloc(self._source_infos,
                                                sizeof(source_info)
                                                * self._max_num_sources)

and something about your data is generating so many sources that it hits a previously unimplemented case.