using +branch/~user/project/branch prevents automatic stacking of new branches pushed to Launchpad
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Critical
|
John A Meinel | ||
Launchpad itself |
Fix Released
|
Low
|
Unassigned |
Bug Description
As of r5736 pushes to Launchpad no longer stack on the development focus by default. The difference at the HPSS level appears to be:
Previously:
9.166 hpss call: 'BzrDirFormat.
//home/
9.166 (to bzr+ssh:
11.236 result: ('.', 'yes', 'no', 'yes', 'Bazaar repository format 2a (needs bzr 1.16 or later)\n', 'Bazaar-NG meta directory, format 1\n', 'Bazaar-NG meta directory, form
at 1\n', 'True', '/~bzr-
Now:
6.664 hpss call: 'BzrDirFormat.
'file:
6.664 (to bzr+ssh:
11.486 result: ('.', 'yes', 'no', 'yes', 'Bazaar repository format 2a (needs bzr 1.16 or later)\n', 'Bazaar-NG meta directory, format 1\n', 'Bazaar-NG meta directory, form
at 1\n', 'False', '', 'file:/
So the different path sent by the client stops the server from replying that it should stack on /~bzr-pqm/
It's possible that this is partly a Launchpad bug, but I'm filing on just bzr initially.
Related branches
- Vincent Ladeuil: Approve
-
Diff: 267 lines (+168/-11)4 files modifiedbzrlib/plugins/launchpad/lp_directory.py (+31/-6)
bzrlib/plugins/launchpad/lp_registration.py (+2/-1)
bzrlib/plugins/launchpad/test_lp_directory.py (+133/-3)
doc/en/release-notes/bzr-2.3.txt (+2/-1)
tags: | added: lpurl |
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Critical |
Changed in bzr: | |
assignee: | nobody → canonical-bazaar (canonical-bazaar) |
Changed in bzr: | |
assignee: | canonical-bazaar (canonical-bazaar) → John A Meinel (jameinel) |
summary: |
- r5736 to resolve lp:foo URLs locally prevents automatic stacking of new + using +branch/~user/project/branch prevents automatic stacking of new branches pushed to Launchpad |
Changed in bzr: | |
status: | Confirmed → In Progress |
Changed in bzr: | |
milestone: | none → 2.4b2 |
status: | In Progress → Fix Committed |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
status: | Invalid → Triaged |
Changed in launchpad: | |
importance: | High → Low |
Changed in launchpad: | |
status: | Triaged → Fix Released |
LP needs to serve the fake bzrdir that's served at /~user/product/.bzr at /+branch/ ~user/product/ .bzr as well. This sounds simple, but translatePath in lp.code. xmlrpc. codehosting is a bit of a mess of competing abstractions...