deprecate Branch.set_revision_history
Bug #730286 reported by
Jelmer Vernooij
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
Branch.
It also complicates the Branch interface unnecessarily for foreign implementations.
Related branches
lp:~jelmer/bzr/deprecate-set-revision-history
- John A Meinel: Approve
-
Diff: 560 lines (+89/-50)18 files modifiedbzrlib/branch.py (+8/-4)
bzrlib/remote.py (+7/-1)
bzrlib/smart/branch.py (+2/-2)
bzrlib/tests/per_branch/test_branch.py (+6/-3)
bzrlib/tests/per_branch/test_check.py (+3/-1)
bzrlib/tests/per_branch/test_get_revision_id_to_revno_map.py (+3/-6)
bzrlib/tests/per_branch/test_hooks.py (+11/-5)
bzrlib/tests/per_branch/test_reconcile.py (+3/-1)
bzrlib/tests/per_branch/test_revision_history.py (+5/-2)
bzrlib/tests/per_controldir/test_controldir.py (+16/-8)
bzrlib/tests/per_workingtree/test_workingtree.py (+1/-1)
bzrlib/tests/test_branch.py (+6/-3)
bzrlib/tests/test_bundle.py (+3/-1)
bzrlib/tests/test_remote.py (+8/-7)
bzrlib/tests/test_smart.py (+1/-1)
bzrlib/tests/test_upgrade.py (+1/-2)
bzrlib/workingtree.py (+2/-2)
doc/en/release-notes/bzr-2.4.txt (+3/-0)
Changed in bzr: | |
status: | Triaged → Confirmed |
Changed in bzr: | |
milestone: | none → 2.4b3 |
status: | Confirmed → Fix Released |
assignee: | nobody → Jelmer Vernooij (jelmer) |
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 3/6/2011 10:19 PM, Jelmer Vernooij wrote: set_revision_ history scales with the size of history - it's the
> Public bug reported:
>
> Branch.
> main reason uncommit is slow on big trees.
>
> It also complicates the Branch interface unnecessarily for foreign
> implementations.
There is no reason to use it over Branch. set_last_ revision_ info() (if we
are missing that api, we should add it.)
I think there is even one that lets you not know the last revno, and use
a revision. Which then uses a Graph object to determine the revno from a
couple of starting points.
I'm fine nuking it, or at least deprecating it, etc.
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
0m6MACgkQJdeBCY SNAAM0qQCfSbWgP RaNcOawrIz0OVZz o8WK pXlaof4jKj6b08t Gq
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk1
rPoAnR7nPnnvGF/
=Yn3X
-----END PGP SIGNATURE-----