EOFError traceback when ftp server drops connection

[Steve Melnikoff]

bzr should give a clean error not a traceback if the ftp server drops the connection.

bzr: ERROR: exceptions.EOFError:

Traceback (most recent call last):
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/explorer/lib/explorer.py", line 1448, in callable_with_cleanup
    task_callable()
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/explorer/lib/explorer.py", line 1609, in _open_location_task
    self._do_view_action, self.dry_run)
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/explorer/lib/location.py", line 160, in __init__
    self.reopen_location()
  File "/Library/Python/2.6/site-packages/bzrlib/plugins/explorer/lib/location.py", line 222, in reopen_location
    self.location)
  File "/Library/Python/2.6/site-packages/bzrlib/bzrdir.py", line 1063, in open_containing_tree_branch_or_repository
    bzrdir, relpath = klass.open_containing(location)
  File "/Library/Python/2.6/site-packages/bzrlib/bzrdir.py", line 967, in open_containing
    return BzrDir.open_containing_from_transport(transport)
  File "/Library/Python/2.6/site-packages/bzrlib/bzrdir.py", line 988, in open_containing_from_transport
    result = BzrDir.open_from_transport(a_transport)
  File "/Library/Python/2.6/site-packages/bzrlib/bzrdir.py", line 941, in open_from_transport
    redirected)
  File "/Library/Python/2.6/site-packages/bzrlib/transport/__init__.py", line 1657, in do_catching_redirections
    return action(transport)
  File "/Library/Python/2.6/site-packages/bzrlib/bzrdir.py", line 928, in find_format
    transport, _server_formats=_server_formats)
  File "/Library/Python/2.6/site-packages/bzrlib/bzrdir.py", line 1949, in find_format
    return format.probe_transport(transport)
  File "/Library/Python/2.6/site-packages/bzrlib/bzrdir.py", line 1959, in probe_transport
    format_string = transport.get_bytes(".bzr/branch-format")
  File "/Library/Python/2.6/site-packages/bzrlib/transport/__init__.py", line 610, in get_bytes
    f = self.get(relpath)
  File "/Library/Python/2.6/site-packages/bzrlib/transport/ftp/__init__.py", line 272, in get
    self._reconnect()
  File "/Library/Python/2.6/site-packages/bzrlib/transport/ftp/__init__.py", line 164, in _reconnect
    connection, credentials = self._create_connection(credentials)
  File "/Library/Python/2.6/site-packages/bzrlib/transport/ftp/__init__.py", line 140, in _create_connection
    connection.connect(host=self._host, port=self._port)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/ftplib.py", line 134, in connect
    self.welcome = self.getresp()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/ftplib.py", line 209, in getresp
    resp = self.getmultiline()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/ftplib.py", line 195, in getmultiline
    line = self.getline()
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/ftplib.py", line 185, in getline
    if not line: raise EOFError
EOFError

bzr 2.2.2 on python 2.6.1 (darwin)
arguments: ['/usr/local/bin/bzr', 'explorer']
encoding: 'UTF-8', fsenc: 'utf-8', lang: 'en_US.UTF-8'
plugins:
  bash_completion /Library/Python/2.6/site-packages/bzrlib/plugins/bash_completion [2.2.2]
  bzrtools /Library/Python/2.6/site-packages/bzrlib/plugins/bzrtools [2.2.0]
  colo /Library/Python/2.6/site-packages/bzrlib/plugins/colo [0.1.0]
  email /Library/Python/2.6/site-packages/bzrlib/plugins/email [unknown]
  explorer /Library/Python/2.6/site-packages/bzrlib/plugins/explorer [1.1.2]
  extmerge /Library/Python/2.6/site-packages/bzrlib/plugins/extmerge [unknown]
  fastimport /Library/Python/2.6/site-packages/bzrlib/plugins/fastimport [0.9.0dev]
  keychain /Library/Python/2.6/site-packages/bzrlib/plugins/keychain [0.1.0]
  launchpad /Library/Python/2.6/site-packages/bzrlib/plugins/launchpad [2.2.2]
  loom /Library/Python/2.6/site-packages/bzrlib/plugins/loom [2.2.1dev]
  netrc_credential_store /Library/Python/2.6/site-packages/bzrlib/plugins/netrc_credential_store [2.2.2]
  news_merge /Library/Python/2.6/site-packages/bzrlib/plugins/news_merge [2.2.2]
  pipeline /Library/Python/2.6/site-packages/bzrlib/plugins/pipeline [unknown]
  qbzr /Library/Python/2.6/site-packages/bzrlib/plugins/qbzr [0.19.3]
  rewrite /Library/Python/2.6/site-packages/bzrlib/plugins/rewrite [0.6.0]
  svn /Library/Python/2.6/site-packages/bzrlib/plugins/svn [1.0.4]
  upload /Library/Python/2.6/site-packages/bzrlib/plugins/upload [1.0.0dev]
  xmloutput /Library/Python/2.6/site-packages/bzrlib/plugins/xmloutput [0.8.6]

[Martin Pool (mbp)]

Hi Steve,

This indicates that the ftp server dropped the connection as soon as we connected. You'll need to check the ftp server logs or ask its admin why it's doing that. We could give a clearer error here.