Activity log for bug #71307

Date Who What changed Old value New value Message
2006-11-11 01:53:02 Matthew Paul Thomas bug added bug
2007-01-03 21:39:42 John A Meinel bzr: status Unconfirmed Confirmed
2007-01-03 21:39:42 John A Meinel bzr: importance Undecided Low
2007-01-03 21:39:42 John A Meinel bzr: statusexplanation Confirmed. The specifics are that: 1) To get the timestamp as part of the output, we actually cheat, and change the filename. So to get: --- lib/canonical/foo 2005-01-02 ... +++ lib/canonical/foo 2006-11-09 ... we actually change the name of the file from 'lib/canonical/foo' to 'lib/canonical/foo' to 'lib/canonical/foo 2005-01-02 ...' We really should have a separate parameter that we pass, so we don't get weird things later. 2) 1970 is the date of the epoch, and it is the date that diff uses when it is trying to say 'no such file'. At one point we didn't have datestamps. Somebody asked for them because they worked better. And they also asked us to not use /dev/null, and instead use the filename. Specifically, you can do: $ mkdir a; echo foo > a/foo; mkdir b $ diff -urN a b --- a/foo 2007-01-03 15:35:10.000000000 -0600 +++ b/foo 1969-12-31 18:00:00.000000000 -0600 @@ -1 +0,0 @@ -foo I was surprised to see 'diff' use 1970 adjusted for the local time zone, but regardless that seems to be the "standard" output. I personally don't really like the datestamps, but if someone finds them useful... So I would argue that we do need to fix the code to use the real filenames, separate from the datestamps. I'm not sure what to do exactly for the rest.
2007-01-04 04:03:20 Matthew Paul Thomas description bzr 0.11.0, Ubuntu 6.10 When I "bzr add" a binary file, then do "bzr diff", I get a result like: === added file 'lib/canonical/launchpad/icing/app-bugs.large.gif' Binary files lib/canonical/launchpad/icing/app-bugs.large.gif 1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/icing/app-bugs.large.gif 2006-11-09 01:41:18 +0000 differ The first line makes sense; the second does not, because either I nor the file existed in 1970. The second line should be omitted. bzr 0.11.0, Ubuntu 6.10 When I "bzr add" a binary file, then do "bzr diff", I get a result like: === added file 'lib/canonical/launchpad/icing/app-bugs.large.gif' Binary files lib/canonical/launchpad/icing/app-bugs.large.gif 1970-01-01 00:00:00 +0000 and lib/canonical/launchpad/icing/app-bugs.large.gif 2006-11-09 01:41:18 +0000 differ The first line makes sense; the second does not, because neither I nor the file existed in 1970. The second line should be omitted.
2009-01-27 17:06:54 Matthew Fuller title "bzr diff" produces silly result for added binary file "bzr diff" produces silly result for binary files
2009-06-22 00:43:07 Martin Pool summary "bzr diff" produces silly result for binary files cluttered output on diff of binary file
2009-06-22 00:43:12 Martin Pool tags diff easy
2010-10-15 00:24:05 Sidnei da Silva bug added subscriber Sidnei da Silva
2017-11-09 00:29:42 Jelmer Vernooij tags diff easy check-for-breezy diff easy
2019-06-29 10:25:58 Jelmer Vernooij tags check-for-breezy diff easy diff easy
2019-06-29 10:34:06 Jelmer Vernooij bug task added brz
2019-06-29 10:34:18 Jelmer Vernooij brz: status New In Progress
2019-06-29 10:34:21 Jelmer Vernooij brz: assignee Jelmer Vernooij (jelmer)
2019-06-29 10:34:10 Launchpad Janitor branch linked lp:~jelmer/brz/diff-binary-weird
2019-06-29 10:34:22 Jelmer Vernooij brz: importance Undecided Medium
2019-06-29 10:34:38 Jelmer Vernooij brz: milestone 3.1.0
2019-10-13 18:10:22 Jelmer Vernooij brz: status In Progress Fix Released