Comment 30 for bug 693880

Revision history for this message
John A Meinel (jameinel) wrote :

This doesn't appear to be properly fixed in the 2.2 series. Or at a minimum, I'm unable to reproduce *this* bug because of another bug.

Looking at the Traceback of the bug, it seems to be a mismatch between xmlrpclib and bzr's implementation of the XMLRPCTransport. However, with bzr 2.2.[1,2,3,4,5-dev] I get:

  File "/home/jameinel/dev/bzr/2.2/work/bzrlib/plugins/launchpad/lp_registration.py", line 195, in send_request
    result = method(*method_params)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1224, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1570, in __request
    verbose=self.__verbose
  File "/home/jameinel/dev/bzr/2.2/work/bzrlib/plugins/launchpad/lp_registration.py", line 78, in request
    return self.parse_response(response)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1449, in parse_response
    if response.getheader("Content-Encoding", "") == "gzip":
AttributeError: addinfourl instance has no attribute 'getheader'

bzr 2.2.5dev on python 2.7.0 (Linux-2.6.35-28-generic-x86_64-with-Ubuntu-10.10-maverick)

Which indicates that bzr-2.2.* is still incompatible with python2.7.

Note that bzr-2.3 is compatible since about b2.

$ bzr revert -r tag:bzr-2.3b1
$ python2.7 ./bzr info lp:bzr
...
  File "/home/jameinel/dev/bzr/2.3/work/bzrlib/plugins/launchpad/lp_registration.py", line 78, in request
    return self.parse_response(response)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1449, in parse_response
    if response.getheader("Content-Encoding", "") == "gzip":
AttributeError: addinfourl instance has no attribute 'getheader'

bzr 2.3b1 on python 2.7.0 (Linux-2.6.35-28-generic-x86_64-with-Ubuntu-10.10-maverick)

However:
$ bzr revert -r tag:bzr-2.3b2
Repository branch (format: unnamed)
Location:
...

So I consider this "Not Fixed" in 2.2. However, if you look at the traceback, it *is* slightly different. So it is possible that another bug in the 2.2 series python2.7 compatibility is masking the fact that *this* bug was fixed.