LP: #xxxx in the commit message should trigger --fixes lp:xxxx

[Didier Roche-Tolomelli]

Binary package hint: bzr

So, when I bzr log, I don't see the bug launchpad link as before. (it was implicitely linked when I had LP: #XXXX in the commit message). Even trying it expictely doesn't work:
$ bzr commit -m "foo" --fixes lp:XXXX

I tried to ditch ~/.bazaar without any success either.

$ bzr --version
Bazaar (bzr) 2.3b2
  Python interpreter: /usr/bin/python 2.6.6
  Python standard library: /usr/lib/python2.6
  Platform: Linux-2.6.37-6-generic-i686-with-Ubuntu-11.04-natty
  bzrlib: /usr/lib/python2.6/dist-packages/bzrlib
  Bazaar configuration: /home/didrocks/.bazaar
  Bazaar log file: /home/didrocks/.bzr.log
[…]

$ bzr plugins -v | grep launchpad
launchpad 2.3b2
   /usr/lib/python2.6/dist-packages/bzrlib/plugins/launchpad

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: bzr 2.3.0~beta2-1
ProcVersionSignature: Ubuntu 2.6.37-6.17-generic 2.6.37-rc3
Uname: Linux 2.6.37-6-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Fri Dec 3 15:50:14 2010
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Alpha i386 (20100918)
ProcEnviron:
 PATH=(custom, user)
 LANG=fr_FR.utf8
 SHELL=/bin/bash
SourcePackage: bzr

[James Westby (james-w)]

I suspect, given that you don't get an error on commit, that this is a problem with /showing/ the
links, rather than recording them. I'm not sure what the best way to inspect the revision to check
that is though.

Thanks,

James

[Vincent Ladeuil (vila)]

@Didier: Do you still encounter the issue ?

[Didier Roche-Tolomelli (didrocks)]

Hey Vincent, seems to be good now with latest natty bzr version.
$ bzr commit -m "foo" --fixes lp:1234
$ bzr log -r -1
[…]
fixes bug(s): https://launchpad.net/bugs/1234

However, this is no more the case for inline comment, like:
bzr commit -m "fix bug LP: #1234"
Wasn't there a shortcut for that, appending --fixes lp: in that case?

[Vincent Ladeuil (vila)]

I never heard about such shortcut :)

Was it builddeb specific may be ?

This could be a nice addition but I don't quite see how to generalize it if it doesn't follow the lp:1234 notation...

[Samuel Bronson (naesten)]

Do we really want *every* launchpad bug mentioned in a commit message to be considered fixed by the commit in question? Couldn't one be mentioned in any other capacity?

[James Westby (james-w)]

On Wed, 09 Feb 2011 20:36:56 -0000, Samuel Bronson <email address hidden> wrote:
> Do we really want *every* launchpad bug mentioned in a commit message to
> be considered fixed by the commit in question? Couldn't one be mentioned
> in any other capacity?

Yes, but if you say "LP: #XXXXX" then it will close the bug on
upload. It's a specially defined syntax to mean "closes this
bug". Therefore I think this change would be appropriate. If you want to
talk about a bug but not close it then use a different syntax (I have
done this many times).

Thanks,

James