disconnecting the sftp transport hangs

[Michael Hudson-Doyle]

Bzrlib hangs when a connected sftp transport is deleted:

>>> from bzrlib.transport import get_transport
>>> t = get_transport('sftp://localhost/')
>>> t.list_dir('.')
['initrd.img', 'lost%2Bfound', 'sys', 'media', 'lib', 'cdrom', 'opt', 'home', 'vmlinuz.old', 'var', 'initrd', 'selinux', 'vmlinuz', 'mnt', 'etc', 'lib32', 'srv', 'dev', 'proc', 'usr', 'nonexistent', 'bin', 'boot', 'root', 'tmp', 'lib64', 'initrd.img.old', 'sbin']
>>> del t
^CException KeyboardInterrupt: KeyboardInterrupt() in <function terminate at 0x26f7050> ignored

Seems present in 2.2.1 through trunk r5544.

[Michael Hudson-Doyle (mwhudson)]

This made all code imports fail in Launchpad. Reverting to 2.2.0 got them going again.

[Max Bowsher (maxb)]

There's a strong likelyhood that this is a dup of bug 659590.... in which case I've already had a fix landed on lp:bzr/2.2 :-)

[Vincent Ladeuil (vila)]

Can you confirm that maxb's fix addresses the issue ?

It is worth releasing 2.2.2 then ?

[Michael Hudson-Doyle (mwhudson)]

Yes, maxb's branch does seem to fix the issue for Launchpad. You might want to land it on trunk :-)

[Launchpad QA Bot (lpqabot)]

Fixed in stable r11960 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11960>.

[Robert Collins (lifeless)]

As this is a rollback, its known-good.

[Max Bowsher (maxb)]

Fixed in bzr 2.2.2, tracked under bug 659590