bzr whoami shouldn't allow empty ("") argument

[Alexander Belchenko]

bzr 2.2.1:

C:\work\>bzr whoami --branch ""
"" does not seem to contain an email address. This is allowed, but not recommended.

C:\work\>bzr whoami
bzr: ERROR: Unable to determine your name.
Please, set your name with the 'whoami' command.
E.g. bzr whoami "Your Name <email address hidden>"

I don't think it's a good behavior.

[Marius Kruger (amanica)]

Why do you thing its bad?
What should it do?

[Alexander Belchenko (bialix)]

Marius Kruger пишет:
> Why do you thing its bad?
> What should it do?

I think bzr shouldn't allow `bzr whoami ""` to succeed and set "" as
identity value, because it's obvious that next time user will get
NoWhoAmi error on commit or some other operations.

--
All the dude wanted was his rug back

[Vincent Ladeuil (vila)]

+1 '' or None leads to the same results so they should be handled the same.

But also note that there have been discussions about *forcing* a valid whoami being a bad thing too...