ignored command should take a path to start searching from

Bug #674192 reported by Neil Martinsen-Burrell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

It would be nice to be able to do "bzr ignored ." to see the files under the current directory that are ignored along with the ignore patterns that apply. It is possible to do "bzr ls --ignored ." but that doesn't show the ignore patterns that apply.

It should probably just use the from_dir parameter to RevisionTree.list_files() to limit the search.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Good idea, that would also provides a useful debug tool when dealing with complex ignore rules.

Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Neil Martinsen-Burrell (nmb) wrote :

How should the file names be printed? Relative to the tree root or relative to the path specified. list_files (as a thin wrapper for inventory.iter_entries) returns the paths relative to the specified from_dir. This is similar to the behavior of commands such as the shell's ls (but not Bazaar's ls). Should we try to match Bazaar's ls command?

Revision history for this message
Vincent Ladeuil (vila) wrote :

I think there are discussions about how paths should be displayed and this hasn't been settled yet (AIUI).

So ideally the underlying implementation should deal with paths relative to tree root and the command itself should decide how it wants to format them.

But specifically for ignored, I think having paths relative to the .bzrignore file itself makes sense.
The user will see which glob matches which path and this matching is done with tree root relative paths...

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.