Occasional AttributeError from Tree.get_file_by_path
Bug #666897 reported by
Michael Gliwinski
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
Tree.get_
self.path2id which may cause an AttributeError exception to be raised when
self._inventory is None. E.g. WorkingTree4+ objects reimplement self.path2id
so it doesn't use self._inventory.
I think Tree.get_
method work for WorkingTree4+ objects as well.
I'm not certain in which exact situations this is a problem, I encountered it
while attempting some modifications in bzr-upload plugin.
See ml for more info and discussion:
https:/
Related branches
lp:~tzeentch-gm/bzr/666897-get-file-by-path-attr-error
- Martin Pool: Approve
-
Diff: 26 lines (+4/-1)2 files modifiedNEWS (+3/-0)
bzrlib/tree.py (+1/-1)
lp:~jelmer/bzr/tree-get-file-by-path
- Martin Packman (community): Approve
- Martin Pool: Needs Information
-
Diff: 108 lines (+20/-14)5 files modifiedbzrlib/tests/blackbox/test_versioning.py (+11/-8)
bzrlib/tests/per_branch/test_stacking.py (+3/-1)
bzrlib/tree.py (+2/-4)
doc/developers/case-insensitive-file-systems.txt (+1/-1)
doc/en/release-notes/bzr-2.5.txt (+3/-0)
Changed in bzr: | |
assignee: | nobody → Michael Gliwinski (tzeentch-gm) |
tags: | added: api |
Changed in bzr: | |
assignee: | Michael Gliwinski (tzeentch-gm) → Jelmer Vernooij (jelmer) |
Changed in bzr: | |
status: | In Progress → Fix Released |
milestone: | none → 2.5b4 |
To post a comment you must log in.
https:/ /code.edge. launchpad. net/~tzeentch- gm/bzr/ 666897- get-file- by-path- attr-error/ +merge/ 39395