TestMultipleRangeWithoutContentLengthServer

Bug #658773 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

In test_http, TestMultipleRangeWithoutContentLengthServer calls MultipleRangeWithoutContentLengthServer which will raise a NameError, and yet the test still passes. See https://code.edge.launchpad.net/~mbp/bzr/597791-http-tests/+merge/37941

Revision history for this message
Vincent Ladeuil (vila) wrote :

There are multiple layers involved when it comes to decide how readv() requests are mapped to http range requests.

In this precise case, the server code that is expected to execute is just never reached by the corresponding tests because the readv requests are turned into encompassing single range requests.

There is a basic flaw in the http tests design: they insist of testing public transport methods leading to tests that are almost blackbox ones and this an example of why it's a bad design.

For these specific tests I suggest to go deeper in the API calls to be just above the http multi range requests building.

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.