bp.launchpad.test_register.TestBranchRegistration.test_onto_transport tests fail on Python 2.7

Bug #654733 reported by Martin Packman on 2010-10-04
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
High
Vincent Ladeuil
bzr (Ubuntu)
High
Unassigned
Natty
High
Jelmer Vernooij

Bug Description

Two launchpad plugin tests fail on Python 2.7, both test_onto_transport and test_onto_transport_unauthenticated.

<http://babune.ladeuil.net:24842/job/selftest-maverick/37/testReport/junit/bzrlib.plugins.launchpad.test_register/TestBranchRegistration/test_onto_transport/>

Traceback (most recent call last):
  File "/home/babune/lib/python/testtools/runtest.py", line 144, in _run_user
    return fn(*args)
  File "/home/babune/lib/python/testtools/testcase.py", line 465, in _run_test_method
    testMethod()
  File "/home/babune/babune/slaves/maverick64.local/workspace/selftest-maverick/bzrlib/plugins/launchpad/test_register.py", line 190, in test_onto_transport
    rego.submit(service)
  File "/home/babune/babune/slaves/maverick64.local/workspace/selftest-maverick/bzrlib/plugins/launchpad/lp_registration.py", line 272, in submit
    self._authenticated)
  File "/home/babune/babune/slaves/maverick64.local/workspace/selftest-maverick/bzrlib/plugins/launchpad/lp_registration.py", line 195, in send_request
    result = method(*method_params)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1224, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1570, in __request
    verbose=self.__verbose
  File "/usr/lib/python2.7/xmlrpclib.py", line 1264, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib/python2.7/xmlrpclib.py", line 1303, in single_request
    self.close()
  File "/usr/lib/python2.7/xmlrpclib.py", line 1378, in close
    if self._connection[1]:
AttributeError: InstrumentedXMLRPCTransport instance has no attribute '_connection'

This is xmlrpclib upstream changes fallout from <http://svn.python.org/view?view=rev&revision=73638> like bug 612096, but just affecting the test scaffolding. Hiding inside this error is another with InstrumentedXMLRPCConnection having no getresponse method, see <https://bugzilla.redhat.com/show_bug.cgi?id=619276#c11> for a nice write up of what's different there.

Related branches

Martin Packman (gz) on 2010-10-04
Changed in bzr:
importance: Undecided → Low
status: New → Confirmed
Martin Packman (gz) on 2010-12-30
tags: added: python27
removed: python2.7
Vincent Ladeuil (vila) wrote :

Bumping to high as we need all tests passing to release for natty.

Changed in bzr:
assignee: nobody → Vincent Ladeuil (vila)
importance: Low → High
Vincent Ladeuil (vila) on 2011-01-11
Changed in bzr:
status: Confirmed → In Progress
Vincent Ladeuil (vila) on 2011-01-11
Changed in bzr:
milestone: none → 2.3b5
status: In Progress → Fix Released
Vincent Ladeuil (vila) wrote :

Strangely enough, this has regressed on FreeBSD. See http://babune.ladeuil.net:24842/job/selftest-freebsd/378/testReport/

Vincent Ladeuil (vila) wrote :

A additional fix is now under review: https://code.launchpad.net/~vila/bzr/654733-xmlrpc-failures/+merge/53216 and should find its way in bzr-2.3.2 and trunk

Changed in bzr:
status: Fix Released → In Progress
Vincent Ladeuil (vila) on 2011-03-14
Changed in bzr:
milestone: 2.3b5 → 2.3.2
status: In Progress → Fix Released
Jelmer Vernooij (jelmer) on 2011-06-08
Changed in bzr (Ubuntu):
status: New → Fix Released
Changed in bzr (Ubuntu Natty):
status: New → In Progress
Jelmer Vernooij (jelmer) on 2011-06-10
Changed in bzr (Ubuntu Natty):
importance: Undecided → High
assignee: nobody → Jelmer Vernooij (jelmer)
Changed in bzr (Ubuntu):
importance: Undecided → High

Accepted bzr into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in bzr (Ubuntu Natty):
status: In Progress → Fix Committed
tags: added: verification-needed
Clint Byrum (clint-fewbar) wrote :

Hello Martin, or anyone else affected,

Accepted bzr into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Jelmer Vernooij (jelmer) wrote :

Verified by running the bzr testsuite from the package in a clean natty install.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bzr - 2.3.4-0ubuntu1

---------------
bzr (2.3.4-0ubuntu1) natty-proposed; urgency=low

  * New upstream release.
   + Fix bzr version number in deprecation warnings. LP: #794960
   + Prevent write attemps on remote branch during "bzr up". LP: #786980
   + Fix conflict handling when two trees involved in a merge have different
     root ids. LP: #805809

bzr (2.3.3-0ubuntu1) natty-proposed; urgency=low

  * New upstream release.
   + Fixes deprecation warning on newer versions of Python. LP: #760435
   + Stops 'bzr push' from copying entire repository if a .bzr directory is
     present without a branch. LP: #465517
   + Fixes undefined local variable error when waiting for lock. LP: #733136
   + Fixes lock contention issues pushing to a bound branch. LP: #733350
   + Transfers less data creating a new stacked branch. LP: #737234
   + Several fixes to the test suite, making it more robust. LP: #654733,
      LP: #751824
   + 'bzr merge --pull --preview' actually shows a preview rather than
     actually merging. LP: #760152
   + bzr smart server now supports UTF-8 user names. LP: #659763
   + user identity can now be set based on username and /etc/mailname, not
     requiring it to be set manually. LP: #616878
   + stacking is now fully transitive. LP: #715000
   + makes in-terminal crash report of plugins much shorter. LP: #716389
 -- Jelmer Vernooij <email address hidden> Thu, 14 Jul 2011 21:12:58 +0200

Changed in bzr (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers