bzr push should not work by default if there are uncommited changes

Bug #65286 reported by Tim Penhey on 2006-10-11
4
Affects Status Importance Assigned to Milestone
Bazaar
Medium
Vincent Ladeuil

Bug Description

I just came across this while working.

bzr push came back with:
0 revision(s) pushed.

Obviously what I wanted to do was push changes (which were still uncommitted).

So needed to commit first. Just suggesting that perhaps by default push should fail if there is uncommitted work.

I can't think of any situations where you would want to push a branch while there is uncommitted work, but someone may - perhaps forcable with --force.

Related branches

John A Meinel (jameinel) on 2007-01-03
Changed in bzr:
importance: Undecided → Wishlist
status: Unconfirmed → Confirmed
Martin Pool (mbp) wrote :

See also bug 206577 asking for this to be done for bzr send, and mysql bug 322808.

Changed in bzr:
importance: Wishlist → Medium
summary: - bzr push should not work by default if there are uncommited changes
+ bzr push and bzr send should should not work by default if there are
+ uncommited changes
summary: - bzr push and bzr send should should not work by default if there are
- uncommited changes
+ bzr push should not work by default if there are uncommited changes
tags: added: mysql
Martin Pool (mbp) wrote :

pqm-send apparently does this check already; it should be unified.

Vincent Ladeuil (vila) on 2009-06-26
Changed in bzr:
assignee: nobody → Vincent Ladeuil (vila)
status: Confirmed → In Progress
Vincent Ladeuil (vila) on 2009-06-29
Changed in bzr:
milestone: none → 1.17
status: In Progress → Fix Committed
John A Meinel (jameinel) wrote :

So I can certainly think of cases, like pushing up what I'm working on before I switch to commit my changes to a different branch. I won't say it is the more common case, but it is a clear use case for having the ability to push when there are uncommitted changes.

John A Meinel (jameinel) wrote :

I should also mention that "pqm-submit" (IMO) is a much stronger action, as it is "merge this into the final product", which is has a different set of implications than "make this work public for someone else to get". Anyway, I'm very happy to have a flag for it, just pointing out places where it isn't exactly like what 'pqm-submit' does today.

>>>>> "jam" == John A Meinel <email address hidden> writes:

    jam> So I can certainly think of cases, like pushing up what
    jam> I'm working on before I switch to commit my changes to a
    jam> different branch.

Same here.

    jam> I won't say it is the more common case, but it is a
    jam> clear use case for having the ability to push when there
    jam> are uncommitted changes.

I always thought so. Yet, for *new* users, that behavior will be
surprising (I know it has been for me, long ago).

So I understand the rationale for making it the default.

Yet, like you, I certainly want to be able to override it, that's
why I added configurations variables in addition to the
command-line option, as soon as I begun working on the bug.

Vincent Ladeuil (vila) on 2009-06-30
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers