tests.test_transport.TestSSHConnections.test_bzr_connect_to_bzr_ssh considered harmful
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Critical
|
John A Meinel |
Bug Description
This test:
- has failed intermittently for months on babune across almost all platforms,
- contains several XXX and one FIXME,
- is huge
- is blocking PQM as of today
My gut feeling is that it tries to test too much at once and should be split.
It may also be related to bug #579530 fixed by spiv in a private ppa
- fails on hardy/py2.
Traceback (most recent call last):
File "/home/
return fn(*args)
File "/home/
testMethod()
File "/home/
t.mkdir('foo')
File "/home/
self.
File "/home/
return self._client.
File "/home/
result, protocol = self.call_
File "/home/
return self._call_
File "/home/
response_tuple = response_
File "/home/
self.
File "/home/
self.
File "/home/
raise errors.
ConnectionReset: Connection closed: Unexpected end of message. Please check connectivity and permissions, and report a bug if problems persist.
------------
- succeds on hardy/py2.
(this is a paramiko private thread):
Exception in thread Thread-6:
Traceback (most recent call last):
File "/usr/lib/
self.run()
File "/usr/lib/
self.
File "/home/
write(bytes)
File "/home/
raise socket.
error: Socket is closed
- succeeds on karmic/py2.4/ haha, skipped, no paramiko here :(
- fails on karmic/
- succeeds on karmic/
(note the switch between 2.4 and 2.5 when going from hardy to karmic)
Related branches
- Vincent Ladeuil: Approve
-
Diff: 112 lines (+31/-24)3 files modifiedNEWS (+3/-0)
bzrlib/tests/stub_sftp.py (+28/-22)
bzrlib/tests/test_transport.py (+0/-2)
Changed in bzr: | |
status: | New → Confirmed |
Changed in bzr: | |
importance: | Undecided → Critical |
Changed in bzr: | |
status: | Confirmed → In Progress |
assignee: | nobody → John A Meinel (jameinel) |
status: | In Progress → Confirmed |
status: | Confirmed → In Progress |
fails on freebsd/ py2.5/paramiko- 1.7.6 with traceback: babune/ lib/python/ testtools/ runtest. py", line 144, in _run_user babune/ lib/python/ testtools/ testcase. py", line 465, in _run_test_method babune/ src/bzr/ trunk/bzrlib/ tests/test_ transport. py", line 981, in test_bzr_ connect_ to_bzr_ ssh babune/ src/bzr/ trunk/bzrlib/ transport/ remote. py", line 242, in mkdir _serialise_ optional_ mode(mode) ) babune/ src/bzr/ trunk/bzrlib/ transport/ remote. py", line 182, in _call2 call(method, *args) babune/ src/bzr/ trunk/bzrlib/ smart/client. py", line 132, in call expecting_ body(method, *args) babune/ src/bzr/ trunk/bzrlib/ smart/client. py", line 145, in call_expecting_body response_ body=True) babune/ src/bzr/ trunk/bzrlib/ smart/client. py", line 90, in _call_and_ read_response body=readv_ body, body_stream= body_stream) babune/ src/bzr/ trunk/bzrlib/ smart/client. py", line 63, in _send_request call(method, *args) babune/ src/bzr/ trunk/bzrlib/ smart/protocol. py", line 1309, in call _write_ end() babune/ src/bzr/ trunk/bzrlib/ smart/protocol. py", line 1133, in _write_end babune/ src/bzr/ trunk/bzrlib/ smart/protocol. py", line 1099, in flush _real_write_ func('' .join(self. _buf)) babune/ src/bzr/ trunk/bzrlib/ smart/medium. py", line 396, in accept_bytes _accept_ bytes(bytes) babune/ src/bzr/ trunk/bzrlib/ smart/medium. py", line 978, in _accept_bytes _medium. _accept_ bytes(bytes) babune/ src/bzr/ trunk/bzrlib/ smart/medium. py", line 794, in _accept_bytes _ensure_ connection( ) babune/ src/bzr/ trunk/bzrlib/ smart/medium. py", line 818, in _ensure_connection directory= /', '--allow-writes']) babune/ src/bzr/ trunk/bzrlib/ transport/ ssh.py" , line 333, in connect_ssh exec_command( cmdline) lib/python2. 5/site- packages/ paramiko/ channel. py", line 213, in exec_command _wait_for_ event() lib/python2. 5/site- packages/ paramiko/ channel. py", line 1084, in _wait_for_event
Traceback (most recent call last):
File "/home/
return fn(*args)
File "/home/
testMethod()
File "/usr/home/
t.mkdir('foo')
File "/usr/home/
self.
File "/usr/home/
return self._client.
File "/usr/home/
result, protocol = self.call_
File "/usr/home/
method, args, expect_
File "/usr/home/
readv_
File "/usr/home/
encoder.
File "/usr/home/
self.
File "/usr/home/
self.flush()
File "/usr/home/
self.
File "/usr/home/
self.
File "/usr/home/
self.
File "/usr/home/
self.
File "/usr/home/
'--
File "/usr/home/
channel.
File "/usr/local/
self.
File "/usr/local/
raise e
EOFError
------------
Note that there is also a warning there:
/usr/local/ lib/python2. 5/site- packages/ Crypto/ Util/randpool. py:40: RandomPool_ DeprecationWarn ing: This application uses RandomPool, which is BROKEN in older releases. See http:// www.pycrypto. org/randpool- broken DeprecationWarn ing)
RandomPool_