'bzr diff --old|new PATH' does silently exists if arg does not exist

[Parth Malwankar]

While viewing a diff I was getting nothing (not difference). I then realized I was passing incorrect PATH to --old/new. Bzr should show an error if path does not exist.

[bzrlib]% ls 300062-invalid-pattern-warnings
ls: cannot access 300062-invalid-pattern-warnings: No such file or directory
[bzrlib]% bzr diff --new 300062-invalid-pattern-warnings
[bzrlib]% bzr diff --old 300062-invalid-pattern-warnings
[bzrlib]% bzr help diff | most
[bzrlib]% bzr version --short
2.2b3
[bzrlib]% bzr revno
5310
[bzrlib]%

[Parth Malwankar (parthm)]

Possibly related. Without the --old/new option, if we do a `bzr diff BRANCH` it silently exits. It doesn't make a difference if branches have common ancestry or not.

[emacs-bzr]% bzr diff ~/src/bzr.dev/trunk
[emacs-bzr]%
[emacs-bzr]% cd ~/src/bzr.dev/trunk
[trunk]% bzr diff ../cmd-ignore-locking
[trunk]%

[Robert Collins (lifeless)]

bzr diff $PATH says 'do a diff of the file/tree found at PATH.

bzr diff --old $PATH says 'diff $PATH with . filtered by [filespecs]'

-Rob

[John A Meinel (jameinel)]

Parth, any update on this? The last comment on the work was from 6 months ago, so I don't think this is really In Progress, but there is a patch here that could be updated and landed.
For now, I'm unsetting In Progress and moving this to a "bug with patch available" sort of status.