Compiled _dirstate_helpers causes crash with specified file commands
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
John A Meinel | ||
2.0 |
Fix Released
|
High
|
John A Meinel | ||
2.1 |
Fix Released
|
High
|
John A Meinel | ||
bzr (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Karmic |
Invalid
|
Undecided
|
Unassigned |
Bug Description
When files are specified to certain commands (seen with stat, diff, and ci at least), and the C _dirstate_helpers is present, bzr will crash:
bzr: ERROR: exceptions.
[...]
File "/home/
cache=
KeyError: 'foo'
Doing a `rm bzrlib/
This error does NOT occur with the 2.1.1 release, but DOES affect bzr.dev, as well as the current heads of the 2.1 and 2.0 branches, and so should block new releases on them :(
Reproduction (alter paths to taste):
#!/bin/sh -x
bzr="/home/
#bzr="/
#bzr="/
#bzr="/
${bzr} init A
(
cd A ;
mkdir foo ;
touch foo/bar ;
${bzr} add ;
${bzr} ci -m 'add' ;
echo "change" > foo/bar ;
# Works
${bzr} stat ;
# Both fail
#${bzr} stat foo ;
${bzr} stat foo/bar ;
)
Related branches
- Robert Collins (community): Approve
-
Diff: 72 lines (+8/-8)1 file modifiedbzrlib/_dirstate_helpers_pyx.pyx (+8/-8)
tags: | added: babune |
Changed in bzr: | |
status: | Confirmed → Fix Released |
assignee: | nobody → John A Meinel (jameinel) |
milestone: | none → 2.2b3 |
Changed in bzr (Ubuntu): | |
status: | New → Fix Released |
Ouch. Could you perhaps confirm that the full test suite works on your machine? Just-in-casely-yrs.