CombinedGraphIndex API changes broken plugins

Bug #580550 reported by Robert Collins on 2010-05-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
High
Unassigned

Bug Description

The change adding index_names to CombinedGraphIndex broke some plugins that were using it by mutating the list they passed in - it naively zips the two lists, when some names are missing indices are dropped. I think this should be guarded against.

John A Meinel (jameinel) wrote :

I believe the most reasonable was to have it check that the len() of appropriate lists matched, so we could at least do some change checking.

Changed in bzr:
importance: Undecided → High
status: New → Confirmed
Jelmer Vernooij (jelmer) wrote :

Hi Rob,

Was this bzr-search specifically? Since this was so long ago (and not on the list to be fixed for 2.3), do you still think this is something that should be fixed?

Changed in bzr:
status: Confirmed → Incomplete
Jelmer Vernooij (jelmer) on 2011-02-01
tags: added: index
Launchpad Janitor (janitor) wrote :

[Expired for Bazaar because there has been no activity for 60 days.]

Changed in bzr:
status: Incomplete → Expired
Changed in bzr:
status: Expired → Confirmed
Jelmer Vernooij (jelmer) on 2017-11-08
tags: added: check-for-breezy
Jelmer Vernooij (jelmer) on 2017-11-12
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers