CombinedGraphIndex API changes broken plugins
Bug #580550 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
High
|
Unassigned |
Bug Description
The change adding index_names to CombinedGraphIndex broke some plugins that were using it by mutating the list they passed in - it naively zips the two lists, when some names are missing indices are dropped. I think this should be guarded against.
tags: | added: index |
Changed in bzr: | |
status: | Expired → Confirmed |
tags: | added: check-for-breezy |
tags: | removed: check-for-breezy |
To post a comment you must log in.
I believe the most reasonable was to have it check that the len() of appropriate lists matched, so we could at least do some change checking.