ValueError in _validate_unicode_text during commit when message contains \r

Bug #552159 reported by John Wythe
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Low
Unassigned

Bug Description

This is the command and trace back
bzr commit --unchanged --commit-time '2006-03-06 17:00:13 -0800' -F /tmp/bk2bzr-25867/msg trm/trmtdv.c trm/trmnt.c trm/trmmem.c trm/trmio.c trm/trmcur.c trm/trmcon.c trm/trm.h isamp/isamp.h isamp/isamp.c isam/isam.h isam/isam.c c/swwin.h c/swsubs.c c/swphar.c c/swchk2.c c/swchk1.c c/sw.h c/rtssd.c c/idef.h brun/sbr/xppn.c brun/sbr/xlock.c brun/sbr/trmchr.c brun/sbr/sleep.c brun/sbr/signal.c brun/sbr/serch.c brun/sbr/sccode.c brun/sbr/priv.c brun/sbr/print.c brun/sbr/popup.c brun/sbr/parg.c brun/sbr/odtim.c brun/sbr/msboxx.c brun/sbr/mkdbf.c brun/sbr/menu.c brun/sbr/input.c brun/sbr/flock.c brun/sbr/dsply.c brun/sbr/common.c brun/sbr/basort.c brun/sbr/amosq.c brun/sbr/accept.c brun/ms/msmisc.h brun/ms/msmisc.c brun/ms/mmosym.h brun/ms/ixmmo.c brun/ms/inmemo.c brun/ms/infld.c brun/exan/xinpdt.c brun/exan/xenxio.h brun/exan/wintxt.c brun/exan/winio.h brun/exan/tgetch.c brun/exan/tclfx.c brun/exan/sql.c brun/exan/serial.c brun/exan/scnwld.h brun/exan/scnwld.c brun/exan/runflg.c brun/exan/rndblk.c brun/exan/prompt.c brun/exan/mysql.c brun/exan/msdio.h brun/exan/mksql.c brun/exan/lokser.c brun/exan/jdate.c brun/exan/inpedt.c brun/exan/imagx.c brun/exan/iapix.c brun/exan/getcur.c brun/exan/getchr.c brun/exan/exanb.h brun/esp/esp.c brun/xxcall.c brun/xwin.h brun/xwin.c brun/xusing.c brun/xtool.c brun/xstmt.c brun/xseq.c brun/xrndm.c brun/xprint.c brun/xpeek.c brun/xnsubs.c brun/xmysql.h brun/xmysql.c brun/xmem.c brun/xisamp.c brun/xisam.c brun/xio.c brun/xinit.c brun/xexpr.c brun/xdll.c brun/xdiag.c brun/thclnt.h brun/thclnt.c brun/brun.h brun/brun.c brun/bcomp.h bcomp/bsubs.c bcomp/bstmt.c bcomp/bopt.c bcomp/bmap.c bcomp/binit.c bcomp/bexpr.c bcomp/bdata.c bcomp/bcomp.h
Committing to: /usr/basic/c_src/ex050404/bzr/
modified brun/xpeek.c
modified brun/xmysql.h
modified brun/exan/winio.h
modified brun/ms/infld.c
modified brun/xmysql.c
modified brun/sbr/flock.c
modified brun/ms/msmisc.h
modified brun/xusing.c
modified brun/sbr/basort.c
modified brun/ms/msmisc.c
modified brun/brun.h
modified c/swphar.c
modified brun/exan/tclfx.c
modified brun/exan/imagx.c
modified brun/brun.c
modified brun/xdiag.c
modified brun/sbr/print.c
modified brun/sbr/signal.c
modified brun/exan/exanb.h
modified brun/sbr/menu.c
modified brun/xinit.c
modified brun/exan/jdate.c
modified brun/xtool.c
modified c/idef.h
modified brun/xseq.c
modified trm/trm.h
modified brun/sbr/odtim.c
modified c/rtssd.c
modified brun/xisamp.c
modified brun/sbr/input.c
modified brun/thclnt.h
modified brun/sbr/serch.c
modified brun/thclnt.c
modified brun/sbr/common.c
modified brun/esp/esp.c
modified trm/trmnt.c
modified brun/exan/rndblk.c
modified trm/trmcur.c
modified brun/xexpr.c
modified brun/exan/serial.c
modified brun/xxcall.c
modified brun/ms/mmosym.h
modified brun/exan/getcur.c
modified brun/exan/mksql.c
modified brun/sbr/xlock.c
modified brun/sbr/dsply.c
modified c/swchk1.c
modified brun/exan/wintxt.c
modified brun/exan/scnwld.h
modified bcomp/bmap.c
modified brun/xio.c
modified brun/exan/scnwld.c
modified brun/xstmt.c
modified bcomp/bopt.c
modified brun/exan/xinpdt.c
modified bcomp/bstmt.c
modified brun/exan/runflg.c
modified c/sw.h
modified bcomp/bcomp.h
modified brun/exan/tgetch.c
modified brun/exan/msdio.h
modified bcomp/binit.c
modified brun/ms/ixmmo.c
modified brun/exan/xenxio.h
modified brun/exan/sql.c
modified trm/trmtdv.c
modified c/swchk2.c
modified brun/sbr/mkdbf.c
modified brun/exan/inpedt.c
modified brun/xdll.c
modified brun/bcomp.h
modified brun/sbr/trmchr.c
modified brun/ms/inmemo.c
modified brun/xisam.c
modified brun/sbr/accept.c
modified isam/isam.c
modified brun/sbr/xppn.c
modified c/swwin.h
modified brun/sbr/amosq.c
modified trm/trmmem.c
modified brun/xrndm.c
modified brun/sbr/sccode.c
modified bcomp/bdata.c
modified brun/sbr/popup.c
modified brun/sbr/priv.c
modified c/swsubs.c
modified isamp/isamp.h
modified brun/sbr/msboxx.c
modified isamp/isamp.c
modified bcomp/bsubs.c
modified brun/sbr/parg.c
modified brun/xmem.c
modified brun/exan/getchr.c
modified brun/exan/iapix.c
modified bcomp/bexpr.c
modified brun/sbr/sleep.c
modified isam/isam.h
modified brun/exan/prompt.c
modified brun/exan/lokser.c
modified trm/trmio.c
modified brun/xnsubs.c
modified trm/trmcon.c
modified brun/exan/mysql.c
modified brun/xwin.c
modified brun/xwin.h
modified brun/xprint.c
aborting commit write group: <exceptions.ValueError instance at 0xb69b754c>
bzr: ERROR: exceptions.ValueError: Invalid value for commit message: u'ChangeSet: 1.1001\nMany files:\n Change UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmtdv.c 1.25 06/03/06 16:55:38 jww 39 39\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmnt.c 1.27 06/03/06 16:55:38 jww 48 48\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmmem.c 1.24 06/03/06 16:55:37 jww 112 112\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmio.c 1.40 06/03/06 16:55:37 jww 22 22\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmcur.c 1.14 06/03/06 16:55:36 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmcon.c 1.13 06/03/06 16:55:35 jww 15 15\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trm.h 1.16 06/03/06 16:55:38 jww 85 85\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nisamp/isamp.h 1.10 06/03/06 16:55:57 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nisamp/isamp.c 1.15 06/03/06 16:55:57 jww 35 35\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nisam/isam.h 1.16 06/03/06 16:55:51 jww 7 7\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nisam/isam.c 1.32 06/03/06 16:55:50 jww 32 32\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swwin.h 1.4 06/03/06 16:55:46 jww 11 11\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swsubs.c 1.96 06/03/06 16:55:44 jww 59 59\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swphar.c 1.3 06/03/06 16:55:43 jww 8 8\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swchk2.c 1.2 06/03/06 16:55:43 jww 5 5\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swchk1.c 1.2 06/03/06 16:55:43 jww 14 14\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/sw.h 1.4 06/03/06 16:55:46 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/rtssd.c 1.2 06/03/06 16:55:42 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/idef.h 1.35 06/03/06 16:55:44 jww 26 26\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/xppn.c 1.2 06/03/06 16:55:14 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/xlock.c 1.39 06/03/06 16:55:09 jww 34 34\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/trmchr.c 1.5 06/03/06 16:55:01 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/sleep.c 1.6 06/03/06 16:55:00 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/signal.c 1.2 06/03/06 16:54:54 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/serch.c 1.33 06/03/06 16:54:43 jww 11 11\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/sccode.c 1.2 06/03/06 16:54:42 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/priv.c 1.3 06/03/06 16:54:38 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/print.c 1.11 06/03/06 16:54:37 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/popup.c 1.2 06/03/06 16:54:36 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/parg.c 1.2 06/03/06 16:54:36 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/odtim.c 1.6 06/03/06 16:54:35 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/msboxx.c 1.5 06/03/06 16:54:35 jww 7 7\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/mkdbf.c 1.4 06/03/06 16:54:34 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/menu.c 1.2 06/03/06 16:54:34 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/input.c 1.8 06/03/06 16:54:33 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/flock.c 1.22 06/03/06 16:54:32 jww 38 38\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/dsply.c 1.3 06/03/06 16:54:32 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/common.c 1.13 06/03/06 16:54:32 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/basort.c 1.32 06/03/06 16:54:31 jww 66 66\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/amosq.c 1.9 06/03/06 16:54:31 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/accept.c 1.10 06/03/06 16:54:30 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/msmisc.h 1.5 06/03/06 16:55:25 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/msmisc.c 1.4 06/03/06 16:55:23 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/mmosym.h 1.11 06/03/06 16:55:24 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/ixmmo.c 1.18 06/03/06 16:55:23 jww 10 10\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/inmemo.c 1.54 06/03/06 16:55:23 jww 43 43\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/infld.c 1.7 06/03/06 16:55:21 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/xinpdt.c 1.3 06/03/06 16:56:31 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/xenxio.h 1.3 06/03/06 16:56:35 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/wintxt.c 1.5 06/03/06 16:56:31 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/winio.h 1.3 06/03/06 16:56:35 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/tgetch.c 1.3 06/03/06 16:56:30 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/tclfx.c 1.7 06/03/06 16:56:30 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/sql.c 1.10 06/03/06 16:56:29 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/serial.c 1.6 06/03/06 16:56:29 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/scnwld.h 1.3 06/03/06 16:56:34 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/scnwld.c 1.9 06/03/06 16:56:28 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/runflg.c 1.3 06/03/06 16:56:28 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/rndblk.c 1.4 06/03/06 16:56:27 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/prompt.c 1.4 06/03/06 16:56:27 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/mysql.c 1.18 06/03/06 16:56:26 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/msdio.h 1.4 06/03/06 16:56:33 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/mksql.c 1.69 06/03/06 16:56:26 jww 9 9\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/lokser.c 1.3 06/03/06 16:56:24 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/jdate.c 1.4 06/03/06 16:56:23 jww 9 9\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/inpedt.c 1.6 06/03/06 16:56:23 jww 31 31\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/imagx.c 1.4 06/03/06 16:56:22 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/iapix.c 1.18 06/03/06 16:56:22 jww 5 5\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/getcur.c 1.23 06/03/06 16:56:22 jww 39 39\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/getchr.c 1.15 06/03/06 16:56:21 jww 20 20\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/exanb.h 1.4 06/03/06 16:56:32 jww 17 17\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/esp/esp.c 1.14 06/03/06 16:56:14 jww 20 20\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xxcall.c 1.16 06/03/06 16:54:23 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xwin.h 1.2 06/03/06 16:54:25 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xwin.c 1.51 06/03/06 16:54:22 jww 61 61\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xusing.c 1.6 06/03/06 16:54:22 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xtool.c 1.2 06/03/06 16:54:21 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xstmt.c 1.35 06/03/06 16:54:21 jww 12 12\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xseq.c 1.14 06/03/06 16:54:01 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xrndm.c 1.25 06/03/06 16:54:20 jww 10 10\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xprint.c 1.11 06/03/06 16:54:20 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xpeek.c 1.4 06/03/06 16:54:19 jww 5 5\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xnsubs.c 1.18 06/03/06 16:54:18 jww 19 19\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xmysql.h 1.61 06/03/06 16:54:24 jww 16 16\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xmysql.c 1.227 06/03/06 16:54:18 jww 88 88\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xmem.c 1.33 06/03/06 16:54:17 jww 20 20\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xisamp.c 1.12 06/03/06 16:54:17 jww 7 7\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xisam.c 1.59 06/03/06 16:54:16 jww 32 32\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xio.c 1.53 06/03/06 16:54:16 jww 14 14\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xinit.c 1.30 06/03/06 16:54:16 jww 14 14\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xexpr.c 1.30 06/03/06 16:54:15 jww 12 12\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xdll.c 1.20 06/03/06 16:54:15 jww 37 37\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xdiag.c 1.10 06/03/06 16:54:14 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/thclnt.h 1.26 06/03/06 16:54:24 jww 15 15\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/thclnt.c 1.126 06/03/06 16:54:13 jww 64 64\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/brun.h 1.86 06/03/06 16:54:24 jww 64 64\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/brun.c 1.70 06/03/06 16:54:12 jww 7 7\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/bcomp.h 1.18 06/03/06 16:54:23 jww 27 27\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bsubs.c 1.10 06/03/06 16:56:05 jww 11 11\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bstmt.c 1.15 06/03/06 16:56:04 jww 21 21\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bopt.c 1.6 06/03/06 16:56:04 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bmap.c 1.8 06/03/06 16:56:03 jww 8 8\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/binit.c 1.9 06/03/06 16:56:03 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bexpr.c 1.9 06/03/06 16:56:03 jww 18 18\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bdata.c 1.8 06/03/06 16:56:02 jww 5 5\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bcomp.h 1.4 06/03/06 16:56:05 jww 21 21\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n'

Traceback (most recent call last):
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commands.py", line 853, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commands.py", line 1055, in run_bzr
    ret = run(*run_argv)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commands.py", line 661, in run_argv_aliases
    return self.run_direct(**all_cmd_args)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commands.py", line 665, in run_direct
    return self._operation.run_simple(*args, **kwargs)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/cleanup.py", line 121, in run_simple
    return _do_with_cleanups(
  File "/usr/local/lib/python2.4/site-packages/bzrlib/cleanup.py", line 156, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/builtins.py", line 3141, in run
    exclude=safe_relpath_files(tree, exclude))
  File "/usr/local/lib/python2.4/site-packages/bzrlib/decorators.py", line 194, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/workingtree_4.py", line 197, in commit
    result = WorkingTree3.commit(self, message, revprops, *args, **kwargs)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/decorators.py", line 194, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/mutabletree.py", line 224, in commit
    possible_master_transports=possible_master_transports,
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commit.py", line 257, in commit
    possible_master_transports=possible_master_transports)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/cleanup.py", line 117, in run
    return _do_with_cleanups(
  File "/usr/local/lib/python2.4/site-packages/bzrlib/cleanup.py", line 156, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/commit.py", line 402, in _commit
    self.rev_id = self.builder.commit(self.message)
  File "/usr/local/lib/python2.4/site-packages/bzrlib/repository.py", line 167, in commit
    self._validate_unicode_text(message, 'commit message')
  File "/usr/local/lib/python2.4/site-packages/bzrlib/repository.py", line 150, in _validate_unicode_text
    raise ValueError('Invalid value for %s: %r' % (context, text))
ValueError: Invalid value for commit message: u'ChangeSet: 1.1001\nMany files:\n Change UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmtdv.c 1.25 06/03/06 16:55:38 jww 39 39\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmnt.c 1.27 06/03/06 16:55:38 jww 48 48\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmmem.c 1.24 06/03/06 16:55:37 jww 112 112\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmio.c 1.40 06/03/06 16:55:37 jww 22 22\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmcur.c 1.14 06/03/06 16:55:36 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trmcon.c 1.13 06/03/06 16:55:35 jww 15 15\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\ntrm/trm.h 1.16 06/03/06 16:55:38 jww 85 85\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nisamp/isamp.h 1.10 06/03/06 16:55:57 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nisamp/isamp.c 1.15 06/03/06 16:55:57 jww 35 35\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nisam/isam.h 1.16 06/03/06 16:55:51 jww 7 7\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nisam/isam.c 1.32 06/03/06 16:55:50 jww 32 32\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swwin.h 1.4 06/03/06 16:55:46 jww 11 11\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swsubs.c 1.96 06/03/06 16:55:44 jww 59 59\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swphar.c 1.3 06/03/06 16:55:43 jww 8 8\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swchk2.c 1.2 06/03/06 16:55:43 jww 5 5\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/swchk1.c 1.2 06/03/06 16:55:43 jww 14 14\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/sw.h 1.4 06/03/06 16:55:46 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/rtssd.c 1.2 06/03/06 16:55:42 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nc/idef.h 1.35 06/03/06 16:55:44 jww 26 26\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/xppn.c 1.2 06/03/06 16:55:14 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/xlock.c 1.39 06/03/06 16:55:09 jww 34 34\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/trmchr.c 1.5 06/03/06 16:55:01 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/sleep.c 1.6 06/03/06 16:55:00 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/signal.c 1.2 06/03/06 16:54:54 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/serch.c 1.33 06/03/06 16:54:43 jww 11 11\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/sccode.c 1.2 06/03/06 16:54:42 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/priv.c 1.3 06/03/06 16:54:38 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/print.c 1.11 06/03/06 16:54:37 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/popup.c 1.2 06/03/06 16:54:36 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/parg.c 1.2 06/03/06 16:54:36 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/odtim.c 1.6 06/03/06 16:54:35 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/msboxx.c 1.5 06/03/06 16:54:35 jww 7 7\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/mkdbf.c 1.4 06/03/06 16:54:34 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/menu.c 1.2 06/03/06 16:54:34 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/input.c 1.8 06/03/06 16:54:33 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/flock.c 1.22 06/03/06 16:54:32 jww 38 38\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/dsply.c 1.3 06/03/06 16:54:32 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/common.c 1.13 06/03/06 16:54:32 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/basort.c 1.32 06/03/06 16:54:31 jww 66 66\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/amosq.c 1.9 06/03/06 16:54:31 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/sbr/accept.c 1.10 06/03/06 16:54:30 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/msmisc.h 1.5 06/03/06 16:55:25 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/msmisc.c 1.4 06/03/06 16:55:23 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/mmosym.h 1.11 06/03/06 16:55:24 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/ixmmo.c 1.18 06/03/06 16:55:23 jww 10 10\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/inmemo.c 1.54 06/03/06 16:55:23 jww 43 43\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/ms/infld.c 1.7 06/03/06 16:55:21 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/xinpdt.c 1.3 06/03/06 16:56:31 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/xenxio.h 1.3 06/03/06 16:56:35 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/wintxt.c 1.5 06/03/06 16:56:31 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/winio.h 1.3 06/03/06 16:56:35 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/tgetch.c 1.3 06/03/06 16:56:30 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/tclfx.c 1.7 06/03/06 16:56:30 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/sql.c 1.10 06/03/06 16:56:29 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/serial.c 1.6 06/03/06 16:56:29 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/scnwld.h 1.3 06/03/06 16:56:34 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/scnwld.c 1.9 06/03/06 16:56:28 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/runflg.c 1.3 06/03/06 16:56:28 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/rndblk.c 1.4 06/03/06 16:56:27 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/prompt.c 1.4 06/03/06 16:56:27 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/mysql.c 1.18 06/03/06 16:56:26 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/msdio.h 1.4 06/03/06 16:56:33 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/mksql.c 1.69 06/03/06 16:56:26 jww 9 9\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/lokser.c 1.3 06/03/06 16:56:24 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/jdate.c 1.4 06/03/06 16:56:23 jww 9 9\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/inpedt.c 1.6 06/03/06 16:56:23 jww 31 31\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/imagx.c 1.4 06/03/06 16:56:22 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/iapix.c 1.18 06/03/06 16:56:22 jww 5 5\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/getcur.c 1.23 06/03/06 16:56:22 jww 39 39\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/getchr.c 1.15 06/03/06 16:56:21 jww 20 20\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/exan/exanb.h 1.4 06/03/06 16:56:32 jww 17 17\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/esp/esp.c 1.14 06/03/06 16:56:14 jww 20 20\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xxcall.c 1.16 06/03/06 16:54:23 jww 6 6\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xwin.h 1.2 06/03/06 16:54:25 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xwin.c 1.51 06/03/06 16:54:22 jww 61 61\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xusing.c 1.6 06/03/06 16:54:22 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xtool.c 1.2 06/03/06 16:54:21 jww 1 1\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xstmt.c 1.35 06/03/06 16:54:21 jww 12 12\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xseq.c 1.14 06/03/06 16:54:01 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xrndm.c 1.25 06/03/06 16:54:20 jww 10 10\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xprint.c 1.11 06/03/06 16:54:20 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xpeek.c 1.4 06/03/06 16:54:19 jww 5 5\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xnsubs.c 1.18 06/03/06 16:54:18 jww 19 19\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xmysql.h 1.61 06/03/06 16:54:24 jww 16 16\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xmysql.c 1.227 06/03/06 16:54:18 jww 88 88\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xmem.c 1.33 06/03/06 16:54:17 jww 20 20\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xisamp.c 1.12 06/03/06 16:54:17 jww 7 7\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xisam.c 1.59 06/03/06 16:54:16 jww 32 32\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xio.c 1.53 06/03/06 16:54:16 jww 14 14\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xinit.c 1.30 06/03/06 16:54:16 jww 14 14\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xexpr.c 1.30 06/03/06 16:54:15 jww 12 12\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xdll.c 1.20 06/03/06 16:54:15 jww 37 37\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/xdiag.c 1.10 06/03/06 16:54:14 jww 4 4\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/thclnt.h 1.26 06/03/06 16:54:24 jww 15 15\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/thclnt.c 1.126 06/03/06 16:54:13 jww 64 64\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/brun.h 1.86 06/03/06 16:54:24 jww 64 64\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/brun.c 1.70 06/03/06 16:54:12 jww 7 7\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbrun/bcomp.h 1.18 06/03/06 16:54:23 jww 27 27\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bsubs.c 1.10 06/03/06 16:56:05 jww 11 11\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bstmt.c 1.15 06/03/06 16:56:04 jww 21 21\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bopt.c 1.6 06/03/06 16:56:04 jww 3 3\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bmap.c 1.8 06/03/06 16:56:03 jww 8 8\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/binit.c 1.9 06/03/06 16:56:03 jww 2 2\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bexpr.c 1.9 06/03/06 16:56:03 jww 18 18\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bdata.c 1.8 06/03/06 16:56:02 jww 5 5\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n\nbcomp/bcomp.h 1.4 06/03/06 16:56:05 jww 21 21\nChange UINT to SW_UINT re conflict compiling with unixODBC.\r\n'

bzr 2.1.0 on python 2.4.6 (Linux-2.4.21-63.EL-i686-with-redhat-3.9-Final)
arguments: ['/usr/local/bin/bzr', 'commit', '--unchanged', '--commit-time', '2006-03-06 17:00:13 -0800', '--<email address hidden>', '-F', '/tmp/bk2bzr-25867/msg', 'trm/trmtdv.c', 'trm/trmnt.c', 'trm/trmmem.c', 'trm/trmio.c', 'trm/trmcur.c', 'trm/trmcon.c', 'trm/trm.h', 'isamp/isamp.h', 'isamp/isamp.c', 'isam/isam.h', 'isam/isam.c', 'c/swwin.h', 'c/swsubs.c', 'c/swphar.c', 'c/swchk2.c', 'c/swchk1.c', 'c/sw.h', 'c/rtssd.c', 'c/idef.h', 'brun/sbr/xppn.c', 'brun/sbr/xlock.c', 'brun/sbr/trmchr.c', 'brun/sbr/sleep.c', 'brun/sbr/signal.c', 'brun/sbr/serch.c', 'brun/sbr/sccode.c', 'brun/sbr/priv.c', 'brun/sbr/print.c', 'brun/sbr/popup.c', 'brun/sbr/parg.c', 'brun/sbr/odtim.c', 'brun/sbr/msboxx.c', 'brun/sbr/mkdbf.c', 'brun/sbr/menu.c', 'brun/sbr/input.c', 'brun/sbr/flock.c', 'brun/sbr/dsply.c', 'brun/sbr/common.c', 'brun/sbr/basort.c', 'brun/sbr/amosq.c', 'brun/sbr/accept.c', 'brun/ms/msmisc.h', 'brun/ms/msmisc.c', 'brun/ms/mmosym.h', 'brun/ms/ixmmo.c', 'brun/ms/inmemo.c', 'brun/ms/infld.c', 'brun/exan/xinpdt.c', 'brun/exan/xenxio.h', 'brun/exan/wintxt.c', 'brun/exan/winio.h', 'brun/exan/tgetch.c', 'brun/exan/tclfx.c', 'brun/exan/sql.c', 'brun/exan/serial.c', 'brun/exan/scnwld.h', 'brun/exan/scnwld.c', 'brun/exan/runflg.c', 'brun/exan/rndblk.c', 'brun/exan/prompt.c', 'brun/exan/mysql.c', 'brun/exan/msdio.h', 'brun/exan/mksql.c', 'brun/exan/lokser.c', 'brun/exan/jdate.c', 'brun/exan/inpedt.c', 'brun/exan/imagx.c', 'brun/exan/iapix.c', 'brun/exan/getcur.c', 'brun/exan/getchr.c', 'brun/exan/exanb.h', 'brun/esp/esp.c', 'brun/xxcall.c', 'brun/xwin.h', 'brun/xwin.c', 'brun/xusing.c', 'brun/xtool.c', 'brun/xstmt.c', 'brun/xseq.c', 'brun/xrndm.c', 'brun/xprint.c', 'brun/xpeek.c', 'brun/xnsubs.c', 'brun/xmysql.h', 'brun/xmysql.c', 'brun/xmem.c', 'brun/xisamp.c', 'brun/xisam.c', 'brun/xio.c', 'brun/xinit.c', 'brun/xexpr.c', 'brun/xdll.c', 'brun/xdiag.c', 'brun/thclnt.h', 'brun/thclnt.c', 'brun/brun.h', 'brun/brun.c', 'brun/bcomp.h', 'bcomp/bsubs.c', 'bcomp/bstmt.c', 'bcomp/bopt.c', 'bcomp/bmap.c', 'bcomp/binit.c', 'bcomp/bexpr.c', 'bcomp/bdata.c', 'bcomp/bcomp.h']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_CA.UTF-8'
plugins:
  launchpad /usr/local/lib/python2.4/site-packages/bzrlib/plugins/launchpad [2.1.0]
  netrc_credential_store /usr/local/lib/python2.4/site-packages/bzrlib/plugins/netrc_credential_store [2.1.0]
  news_merge /usr/local/lib/python2.4/site-packages/bzrlib/plugins/news_merge [2.1.0]

Martin Pool (mbp)
summary: - bzr commit crashed
+ ValueError in _validate_unicode_text during commit
Revision history for this message
John Wythe (john-wythe) wrote : Re: ValueError in _validate_unicode_text during commit

I tried shortening the data in the message file, and removing the file names from the command line to let commit determine the files. Both cases crashed as well.

Revision history for this message
Martin Pool (mbp) wrote :

This is happening because the commit message contains \r (carriage-return) characters. Probably bk2bzr should be stripping them out, and we should at least give you a nicer message when this happens, or perhaps just strip them inside bzrlib.

summary: - ValueError in _validate_unicode_text during commit
+ ValueError in _validate_unicode_text during commit when message contains
+ \r
Changed in bzr:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
John Wythe (john-wythe) wrote :

Even trying to commit just one file crashes.

Revision history for this message
John Wythe (john-wythe) wrote :

Okay I see that now. I can make bk2bzr strip them. Thanks!

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.