Last character of path stripped in result message

[Martin von Gagern]

bzr-svn sometimes causes bzr to drop the last character of a branch URL.

$ bzr up
Tree is up to date at revision 350 of branch http://svn.unix-ag.uni-kl.de/vpnc/trun
$ bzr info | grep "checkout of"
        checkout of branch: http://svn.unix-ag.uni-kl.de/vpnc/trunk
$ bzr plugins | grep ^svn
svn 1.0.2
$ bzr --version | head -n1
Bazaar (bzr) 2.1.0

The reason seems to be that
1. bzrlib.plugins.svn.branch.SvnBranch.__init__ does a lot of strip("/") and rstrip("/") and
2. bzrlib.builtins.cmd_update.update drops the last char unconditionally:
        # get rid of the final '/' and be ready for display
        branch_location = urlutils.unescape_for_display(branch_location[:-1],
                                                        self.outf.encoding)

I don't know which one is to blame. I personally would prefer an rstrip('/') in cmd_update, but perhaps there is a good reason to do things differently, and perhaps there are other places where bzrlib expects a path with trailing slash as well, so adjusting bzr-svn might be a more complete solution, albeit probably requiring more work as well.

[Martin Pool (mbp)]

that seems pretty obviously silly and easy to fix on the bzr side

[Lars Hoss (lars-hoss)]

Had the same problem today as well. Running on bzr-svn 1.0.3-dev.

[Martin Pool (mbp)]

@lars but are you using bzr.dev tip?