Bazaar

Pdf files content included on merge proposal diff.

Bug #540400 reported by Ronaldo Maia on 2010-03-17

This bug report is a duplicate of: Bug #218128: want a way to mark files as binary even if they look like text (eg pdf files). Edit Remove

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Bazaar	New	Undecided	Unassigned

The following merge proposal shows a diff with the content of a whole pdf file that was changed.

It would be interesting to only indicate that a binary file was changed (I am not sure if this happens to other types of binary files)

Diogo Matsubara (matsubara) on 2010-03-17

affects:

launchpad → launchpad-code

Revision history for this message

Aaron Bentley (abentley) wrote on 2010-03-17:

We generate our diffs with bzr

affects:

launchpad-code → bzr

Revision history for this message

Tim Penhey (thumper) wrote on 2010-03-18:

The way that bzr determines a file is binary is a bit crude. In that it checks for a null byte in the first 1024 characters of the file.

Your pdf file probably doesn't have one.

Perhaps bzrlib could also use the guessed mimetype of the file to help determine if the file is text or not.

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Bug watches keep track of this bug in other bug trackers.