no clear error message when failing to push via http when bzr+http POSTs work and plain http GETs don't

[Guillermo Gonzalez]

Hi,

spiv requested to file abug about this, please change the title to make it more clear or mark as dupe (I couldn't find a dupe)

I got this error while running:
$> bzr -Dhpss -Dhttp push https+urllib://trac.usla.org.ar/bzr/prueba_bzr
HTTPS trac.usla.org.ar, Realm: 'usla' username: XXXXXX
HTTPS <email address hidden>, Realm: 'usla' password:
bzr: ERROR: Not a branch: "https+urllib://trac.usla.org.ar/bzr/prueba_bzr/".

But there is a branch in that location, attached the full .bzr.log.

P.S: 'bzr push https://trac.usla.org.ar/bzr/prueba_bzr' works ok, without pycurl installed.

[Andrew Bennetts (spiv)]

The specific issue here seems to be that bzr+http is working fine, but at some early point bzr tries to do a plain GET of the branch-format file (rather than via HPSS), which gets a 404, and so you get a typically unhelpful NotABranch error.

I think the primary issue here is a server misconfiguration (it's always going to be confusing to have some URLs work for HPSS POSTs but not HTTP GETs), but I think it's possible for bzr to do better here.

Some things we could do to improve this:
 * report back to the user that it appears that plain HTTP is failing, not HPSS, so that they can give a useful "it doesn't work" report to the site admin
 * try an HPSS get if HTTP GET fails
 * stop using VFS entirely!
 * maybe something else?

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> The specific issue here seems to be that bzr+http is working fine, but
> at some early point bzr tries to do a plain GET of the branch-format
> file (rather than via HPSS), which gets a 404, and so you get a
> typically unhelpful NotABranch error.
>

IIRC, if you "bzr branch http://" then we do normal GET via http, but we
do smart requests via POST.

If you do "bzr branch bzr+http://" then all VFS activity goes via POST
and smart requests, rather than direct http requests.

See other comments in the past about hosting using MS IIS, and issues
with that.

The good of using this method is that static files (most format files,
etc) can be cached through intermediate proxies, etc. The bad is that if
people have incorrect configurations then they get a bit of garbage.

John
=:->

 status: confirmed
 importance: low

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuD7dcACgkQJdeBCYSNAAOliQCeKq8tLMauv7BS0lLyl80Qep+V
SuIAn3BUE+8FvjwMmvzBffe0BrT1Dv98
=IsVG
-----END PGP SIGNATURE-----