RemoteBzrDir.create_workingtree has wrong signature

Bug #524627 reported by Neil Martinsen-Burrell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Low
Neil Martinsen-Burrell

Bug Description

This is almost certainly operator error to pass remote URLs where local paths are intended, but because of the missing arguments, it doesn't even get a chance to raise the NotLocalUrl exception. I can't seem to find a way to trigger this from the CLI outside of my plugin code.

$ bzr colo-init bzr+ssh://localhost/Users/nmb/tmp/test5
Shared repository (format: unnamed)
Location:
  shared repository: bzr+ssh://localhost/Users/nmb/tmp/test5/.bzr/branches/
Created a repository branch (format: unnamed)
Using shared repository: bzr+ssh://localhost/Users/nmb/tmp/test5/.bzr/branches/
bzr: ERROR: exceptions.TypeError: create_workingtree() got an unexpected keyword argument 'accelerator_tree'

Traceback (most recent call last):
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 831, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 1033, in run_bzr
    ret = run(*run_argv)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 639, in run_argv_aliases
    return self.run_direct(**all_cmd_args)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 643, in run_direct
    return self._operation.run_simple(*args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/cleanup.py", line 122, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/cleanup.py", line 156, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/Users/nmb/.bazaar/plugins/colo/commands.py", line 159, in run
    outf=self.outf,
  File "/Users/nmb/.bazaar/plugins/colo/commands.py", line 118, in init_workspace
    lightweight=True)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/commands.py", line 643, in run_direct
    return self._operation.run_simple(*args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/cleanup.py", line 122, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/cleanup.py", line 156, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/builtins.py", line 1350, in run
    accelerator_tree, hardlink)
  File "/Users/nmb/src/bzr/bzr.dev/bzrlib/branch.py", line 1334, in create_checkout
    hardlink=hardlink)
TypeError: create_workingtree() got an unexpected keyword argument 'accelerator_tree'

bzr 2.2.0dev1 on python 2.6.4 (Darwin-9.8.0-i386-32bit)
arguments: ['/Users/nmb/usr/bin/bzr', 'colo-init', 'bzr+ssh://localhost/Users/nmb/tmp/test5']
encoding: 'UTF-8', fsenc: 'utf-8', lang: 'en_US.UTF-8'
plugins:
  automirror /Users/nmb/.bazaar/plugins/automirror [0.1.0]
  bzrtools /Users/nmb/.bazaar/plugins/bzrtools [2.1.0]
  colo /Users/nmb/.bazaar/plugins/colo [0.0.3dev]
  colocated /Users/nmb/.bazaar/plugins/colocated [0.4.16dev]
  explorer /Users/nmb/.bazaar/plugins/explorer [1.0.0rc1]
  fastimport /Users/nmb/.bazaar/plugins/fastimport [0.9.0dev]
  git /Users/nmb/.bazaar/plugins/git [0.4.4dev]
  latex_version_info /Users/nmb/.bazaar/plugins/latex_version_info [0.0.2]
  launchpad /Users/nmb/src/bzr/bzr.dev/bzrlib/plugins/launchpad [2.2.0dev1]
  netrc_credential_store /Users/nmb/src/bzr/bzr.dev/bzrlib/plugins/netrc_credential_store [2.2.0dev1]
  news_merge /Users/nmb/src/bzr/bzr.dev/bzrlib/plugins/news_merge [2.2.0dev1]
  pipeline /Users/nmb/.bazaar/plugins/pipeline [unknown]
  qbzr /Users/nmb/.bazaar/plugins/qbzr [0.19.0dev]
  rst2html /Users/nmb/.bazaar/plugins/rst2html [0.0.2]
  xmloutput /Users/nmb/.bazaar/plugins/xmloutput [0.8.7.dev]

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    including this traceback and a description of the problem.

Martin Pool (mbp)
Changed in bzr:
importance: Undecided → Low
status: New → In Progress
Martin Packman (gz)
Changed in bzr:
milestone: none → 2.3b2
status: In Progress → Fix Committed
assignee: nobody → Neil Martinsen-Burrell (nmb)
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.