Bazaar Version Control System

bzr-explorer don't work if installing by bzr-2.1.0 standalone installer.

Reported by IWATA Hidetaka on 2010-02-19
34
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Bazaar
Critical
Ian Clatworthy
Bazaar Explorer
Undecided
Unassigned
Bazaar Windows Installers
Critical
Ian Clatworthy

Bug Description

I installed bzr-explorer from bzr-2.1.0 windows standalone installer.
> http://launchpad.net/bzr/2.1/2.1.0/+download/bzr-2.1.0-1-setup.exe

Then
 * Menu bar is not shown.
 * Selecting File(&F) > Accessories will crash.

In bazaar\plugins\explorer, these files does not exist. This maybe cause this probrem.
 * skin\editors.conf
 * skin\toolbars.xml

Martin Pool (mbp) wrote :

This is a known bug in packaging.

Changed in bzr:
importance: Undecided → Critical
status: New → Confirmed
milestone: none → 2.1.1
tags: added: packaging win32
Ian Clatworthy (ian-clatworthy) wrote :

The problem is in the Windows packaging, not explorer itself.

Changed in bzr-windows-installers:
assignee: nobody → Ian Clatworthy (ian-clatworthy)
importance: Undecided → Critical
status: New → Confirmed
Changed in bzr-explorer:
status: New → Invalid
Ian Clatworthy (ian-clatworthy) wrote :

As an immediate work-around, perhaps we can comment out the 2 lines in setup.py that are skipping files inslde plugins based on their extension?

The next step after that is to copy all the py2exe-related content out of setup.py inside bzr and move it into the installer project. build-installer.bat can call something other than setup.py to execute the logic it needs.

Ian Clatworthy (ian-clatworthy) wrote :

The linked branch has my progress so far on this, namely migrating the setup.py py2exe logic (from bzr's setup.py) to a new script/class in the Windows Installer project. That script/class needs to be hooked in and tested. I'm hoping John can have a go at that in the coming hours as I need to sleep now.

FWIW, I've also started work on migrating build-installer.bat.in to build-installer.py.in: I find the bat script template very hard to change and debug. Again it's yet to be tested and debugged but it may help get this (and follow-on improvements) working sooner.

Changed in bzr-windows-installers:
assignee: Ian Clatworthy (ian-clatworthy) → John A Meinel (jameinel)
Changed in bzr:
assignee: nobody → John A Meinel (jameinel)
Ian Clatworthy (ian-clatworthy) wrote :

Also, if we remove the dependence on bzr's setup.py completely, then we don't need a 2.1.1 in order to get this fixed.

In any case, we certainly need a new installer made available ASAP given the various issues uncovered in testing: this one, news-merge plugin missing and old chm files.

Ian Clatworthy (ian-clatworthy) wrote :

John,

Is my branch heading in the right direction? Or should we just comment out the two lines in setup.py inside bzr causing the files to be omitted for now?

Ian Clatworthy (ian-clatworthy) wrote :

After discussions with poolie today, I'll take on responsibility for getting this fixed and getting a new Windows installer built ASAP.

Changed in bzr-windows-installers:
assignee: John A Meinel (jameinel) → Ian Clatworthy (ian-clatworthy)
Changed in bzr:
assignee: John A Meinel (jameinel) → Ian Clatworthy (ian-clatworthy)
Changed in bzr-windows-installers:
status: Confirmed → Fix Released
Martin Pool (mbp) wrote :
Changed in bzr:
status: Confirmed → In Progress
Martin Pool (mbp) wrote :

Ian's fix is merged so I think this is fixreleased and will be ok in 2.1.1.

Changed in bzr:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers