shelve UI messages: is it possible to improve them?

[Alexander Belchenko]

This is dump from IRC of short chat between me and Aaron. It relates to the fact that some confirmation questions in the end of shelve operation could be improved by using more context.

[18:04] <bialix> abentley: shelve with editor works very nice, thanks!
[18:04] <abentley> bialix, you're welcome.

[18:07] <bialix> abentley: one minor UI thing: if I've invoked editor to work with several changes in one file then it invoked only once, that's ok; but final confirmation slightly misleading: "Shelve 2 changes?" -- and I think: "strange, I've edited the file only once".
[18:07] <abentley> bialix, I believe that means "two lines changed".
[18:08] <bialix> it's not very obvious
[18:08] <bialix> usually it's the count of hunks
[18:08] <bialix> abentley: maybe "Shelve selected changes" would be more neutral
[18:09] <abentley> bialix, that could make sense.

[18:10] <bialix> abentley: also, if I've invoked "shelve --destroy" it will be nice to see more strong confirmation question: "Destroy selected changes?". but all this UI things, maybe I'm wrong
[18:11] <abentley> bialix, yes, there's always tension between providing a consistent UI and a specific UI.
[18:11] <bialix> perhaps I need dump this questions as bug report?
[18:11] <abentley> bialix, sure. They're good questions, and I'm not sure what the right answers are.

So, here is bug report as starting point.