bzrlib.merge do_merge has fragile cleanups
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Andrew Bennetts | ||
2.1 |
Fix Released
|
Undecided
|
Andrew Bennetts |
Bug Description
Hi,
self.tt = TreeTransform(
try:
finalize can raise exceptions (ImmortalPendin
an existing exception. It would be great to at least know what exception
was being masked, or to use bzrlib.cleanup instead of finally.
Thanks,
James
Related branches
- Martin Pool: Approve
-
Diff: 205 lines (+59/-58)3 files modifiedNEWS (+9/-0)
bzrlib/cleanup.py (+2/-2)
bzrlib/merge.py (+48/-56)
Changed in bzr: | |
status: | Confirmed → In Progress |
Fair enough. I'll submit a branch to use bzrlib.cleanup in merge.py.