Confusing error message when accessing a branch I don't have a access on Launchpad

[Francis J. Lacoste]

If you call open_branch on a private branch that you don't have access to, the exception message is confusing.

For example, lp:~~launchpad-pqm/launchpad/production-devel is a private branch. Here is the stack trace of the error:

          File "/usr/lib/python2.5/site-packages/bzrlib/remote.py", line 280, in open_branch
            response = self._get_branch_reference()
          File "/usr/lib/python2.5/site-packages/bzrlib/remote.py", line 254, in _get_branch_reference
            response = self._call('BzrDir.open_branchV2', path)
          File "/usr/lib/python2.5/site-packages/bzrlib/remote.py", line 54, in _call
            self._translate_error(err, **err_context)
          File "/usr/lib/python2.5/site-packages/bzrlib/remote.py", line 132, in _translate_error
            _translate_error(err, bzrdir=self, **context)
          File "/usr/lib/python2.5/site-packages/bzrlib/remote.py", line 2774, in _translate_error
            raise errors.NotBranchError(path=find('bzrdir').root_transport.base)
        bzrlib.errors.NotBranchError: Not a branch: "bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/".

As you see, the last component is missing from the branch URL. lp:~launchpad-pqm/launchpad/production-devel was the input.

[John A Meinel (jameinel)]

Looking at the failure for gnome-control-center and looking at the changelog I see, this appears to just be a simple failure to handle any non-ascii author names.
Specifically," -- Sebastian Dr\xc3\xb6ge ..." is listed many times as the author for part of the changelog. My guess is that the code simply is mixing decoded author names with encoded author names.

Arguably a 'correct' fix is to change python-debian to use Unicode names, but I'm assuming we don't really get to touch that code, so we should be doing so in bzr-builddeb.

[Martin Pool (mbp)]

On 3 February 2010 19:21, John A Meinel <email address hidden> wrote:
> Looking at the failure for gnome-control-center and looking at the changelog I see, this appears to just be a simple failure to handle any non-ascii author names.
> Specifically," -- Sebastian Dr\xc3\xb6ge ..." is listed many times as the author for part of the changelog. My guess is that the code simply is mixing decoded author names with encoded author names.
>
> Arguably a 'correct' fix is to change python-debian to use Unicode
> names, but I'm assuming we don't really get to touch that code, so we
> should be doing so in bzr-builddeb.

ewrongtab?

--
Martin <http://launchpad.net/~mbp/>

[John A Meinel (jameinel)]

Looks like I assigned this accidentally. Meant to assign a different bug.

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On 3 February 2010 19:21, John A Meinel <email address hidden> wrote:
>> Looking at the failure for gnome-control-center and looking at the changelog I see, this appears to just be a simple failure to handle any non-ascii author names.
>> Specifically," -- Sebastian Dr\xc3\xb6ge ..." is listed many times as the author for part of the changelog. My guess is that the code simply is mixing decoded author names with encoded author names.
>>
>> Arguably a 'correct' fix is to change python-debian to use Unicode
>> names, but I'm assuming we don't really get to touch that code, so we
>> should be doing so in bzr-builddeb.
>
> ewrongtab?
>

yep. Meant to be on bug #508251

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktp78EACgkQJdeBCYSNAANGsgCfRJpSCccGp/qydB36UQclWR8+
D1cAn32ObmZmRxI/xzJlGB9KyE9cngxn
=+UKC
-----END PGP SIGNATURE-----