bzr push confused by existing pack file

Bug #516179 reported by Martin von Gagern on 2010-02-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Medium
Unassigned

Bug Description

I did a bzr push over sftp to savannah. Due to a dropped connection the push failed. I broke the lock forcefully, but I doubt that waiting for the lock to time out would have changed a thing. Full log attached. Subsequent pushes faild this way:

$ bzr push
Using saved push location: sftp://<email address hidden>/srv/bzr/wdiff/trunk/
Doing on-the-fly conversion from <RepositoryFormat2a> to <RepositoryFormatKnitPack5RichRoot>.
This may take some time. Upgrade the repositories to the same format for better performance.

bzr: ERROR (ignored): GraphIndex('sftp://<email address hidden>/srv/bzr/wdiff/.bzr/repository/indices/4c52ee0586adc8546ec9d26e89e64abc.rix')
bzr: ERROR: Generic path error: 'dz0ksu1rtwr7m5hdz7ey.pack': Failure: unable to rename to '../packs/4c52ee0586adc8546ec9d26e89e64abc.pack')

Running sftp manually I could see that the file in question did in fact exist. It wasn't mentioned in the pack-names intex, though.

I guess bzr should remove / overwrite the old pack instead of dying.

Martin von Gagern (gagern) wrote :
Robert Collins (lifeless) wrote :

So, on SFTP rename-over-the-top fails, and the reason the pack already exists is a dropped SFTP connection during a prior attempt to do the same push. We should indeed remove an existing pack in this case as we're inside the critical section && know its not in use.

Robert Collins (lifeless) wrote :

Same for index files.

Martin Pool (mbp) on 2010-02-02
Changed in bzr:
importance: Undecided → Medium
status: New → Confirmed
Martin Pool (mbp) on 2010-02-02
tags: added: 2a sftp
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments