bzr help files - update help for Vista/Win7 & show actual location of bazaar.conf

[Aliaksei Vasileuski]

"bzr help files" now says:
On Linux: ~/.bazaar/bazaar.conf
On Windows: C:\\Documents and Settings\\username\\Application Data\\bazaar\\2.0\\bazaar.conf

Contains the user's default configuration. ,,,

But that is incorrect on Win7 (and Vista, AFAIK), the following should be added:
On WIndows 7/Vista: C:\\Users\\username\\AppData\\Roaming\\bazaar\\2.0\\bazaar.conf

Also we can show actual location of bazaar.conf file on current system.

[Martin Pool (mbp)]

I believe we get the directory to use from the system, and then show that in the help. Specifically in win32utils we use
CSIDL_LOCAL_APPDATA

Is it more appropriate that this be in roaming data? Since at least some of it is per-host configuration it seems not.

Perhaps we should search both?

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> I believe we get the directory to use from the system, and then show that in the help. Specifically in win32utils we use
> CSIDL_LOCAL_APPDATA
>
> Is it more appropriate that this be in roaming data? Since at least
> some of it is per-host configuration it seems not.
>
> Perhaps we should search both?
>
> ** Tags added: win32
>
> ** Changed in: bzr
> Status: New => Confirmed
>
> ** Changed in: bzr
> Importance: Undecided => Low
>

I'm pretty sure it is in Roaming and not Local.

appdata = _get_sh_special_folder_path(CSIDL_APPDATA)
...
local = _get_sh_special_folder_path(CSIDL_LOCAL_APPDATA)

So I think we use both, depending on what we are looking for. (Though
looking right now I only see us calling
win32utils.get_appdata_location_unicode().)

$TMP tends to be be in Local, as appropriate. Arguably some of
bazaar.conf could be considered local, but I think it generally fits
Roaming (if I had to pick between the two.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktUb+EACgkQJdeBCYSNAAOQLQCdHNYOvrcNTtRc50re/vsuFbUX
Y+EAoLJsQFa2SeqV0C+5QY7FvcbST/Kq
=sNkx
-----END PGP SIGNATURE-----