StaticTuple_dealloc does not give useful debugging information

[Matt Nordhoff]

StaticTuple_dealloc tries to remove the ST from the SimpleSet of interned STs. If this goes Horribly Wrong, it simply does Py_FatalError("deletion of interned StaticTuple failed"), which is nice, but doesn't help you figure out what exactly happened.

(bzrlib/_static_tuple_c.c, around line 120)

It should do something like:

* If SimpleSet_Discard returns 0 (object not present in the set), say that.

* If it returns -1 (exception), print the exception.

* If something even more bizarre happens, um, bake brownies?

Maybe it should include other stuff too (repr of the ST itself? could be really long...), I dunno.

(Please mark this super-low priority. :) Wanted to have a record of it, though.)

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matt Nordhoff wrote:
> Public bug reported:
>
> StaticTuple_dealloc tries to remove the ST from the SimpleSet of
> interned STs. If this goes Horribly Wrong, it simply does
> Py_FatalError("deletion of interned StaticTuple failed"), which is nice,
> but doesn't help you figure out what exactly happened.
>
> (bzrlib/_static_tuple_c.c, around line 120)
>
> It should do something like:
>
> * If SimpleSet_Discard returns 0 (object not present in the set), say
> that.
>
> * If it returns -1 (exception), print the exception.
>
> * If something even more bizarre happens, um, bake brownies?
>
> Maybe it should include other stuff too (repr of the ST itself? could be
> really long...), I dunno.
>
> (Please mark this super-low priority. :) Wanted to have a record of it,
> though.)

mmm... brownies

  importance: low
  status: confirmed

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksDJiIACgkQJdeBCYSNAAMlUgCgsf35pW7H2EWKJAWkY5T8SNO6
NA4An0+o5DyTCasXdEasVihbDhB5ybvC
=P7k7
-----END PGP SIGNATURE-----