commit/qcommit: non-ascii characters in --fixes XXX leads to traceback
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Undecided
|
Unassigned | ||
QBzr |
Confirmed
|
Medium
|
Unassigned |
Bug Description
Using german umlaut in description when checking in produces:
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "C:/Program Files (x86)/Bazaar/
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "optparse.pyo", line 1387, in parse_args
File "optparse.pyo", line 1427, in _process_args
File "optparse.pyo", line 1502, in _process_long_opt
File "optparse.pyo", line 774, in process
File "optparse.pyo", line 794, in take_action
File "bzrlib\
UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 1: ordinal not in range(128)
bzr 2.0.1 on python 2.5.4 (Windows-
arguments: ['C:\\Program Files (x86)\\
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
bzrtools C:\Program Files (x86)\Bazaar\
explorer C:\Program Files (x86)\Bazaar\
launchpad C:\Program Files (x86)\Bazaar\
netrc_
qbzr C:\Program Files (x86)\Bazaar\
rebase C:\Program Files (x86)\Bazaar\
svn C:\Program Files (x86)\Bazaar\
upload C:\Program Files (x86)\Bazaar\
xmloutput C:\Program Files (x86)\Bazaar\
*** Bazaar has encountered an internal error. This probably indicates a
bug in Bazaar. You can help us fix it by filing a bug report at
https:/
including this traceback and a description of the problem.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
marno wrote:
> Public bug reported:
>
> Using german umlaut in description when checking in produces:
...
> Traceback (most recent call last):
...
> File "bzrlib\ option. pyo", line 291, in _optparse_callback Vista-6. 0.6002- SP2) Bazaar\ \bzr.exe' , 'qsubprocess', '"commit" "-m" "Textlogfile f\xfcr Buchungen speicherte im Webroot von xxxr.de" "apps/frontend/ modules/ buchen/ actions/ actions. class.php" "--fixes= Textlogfile" "--fixes=f\xfcr" "--fixes=Buchungen" "--fixes= speicherte" "--fixes=im" "--fixes=Webroot" "--fixes=von" "--fixes=xxx.de"']
> UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in position 1: ordinal not in range(128)
>
> bzr 2.0.1 on python 2.5.4 (Windows-
> arguments: ['C:\\Program Files (x86)\\
> encoding: 'cp1252', fsenc: 'mbcs', lang: None
affects qbzr
Seems to be an issue with how qbzr is passing arguments to the bzr
subprocess, and then how bzr itself tries to parse those. I'm adding
qbzr, just in case there is something that it could be doing differently.
My initial guess is that it is an issue with how 'qsubprocess' is being
invoked. Because the '"commit..."' is being supplied as a single string
argument to the command.
Also, '"--fixes=f\xfcr"' is not usually how '--fixes' is used. Usually
you give it something like "--fixes lp:12345" or "--fixes gnome:2345".
John enigmail. mozdev. org/
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkr qDT4ACgkQJdeBCY SNAAN9/ wCdHiXag5l1A81s s3i/YpJDWD/ 7 2SSd0c1rpLz3eud K4
5SUAn3UiNzY77r7
=srnn
-----END PGP SIGNATURE-----