| 2006-05-20 09:00:50 |
Nicholas Allen |
bug |
|
|
added bug |
| 2006-08-05 18:44:05 |
Matthieu Moy |
bzr: status |
Unconfirmed |
Confirmed |
|
| 2006-08-05 18:44:05 |
Matthieu Moy |
bzr: statusexplanation |
|
Confirmed on the mailing-list. |
|
| 2006-09-02 03:55:38 |
John A Meinel |
bzr: status |
Confirmed |
In Progress |
|
| 2006-09-02 03:55:38 |
John A Meinel |
bzr: assignee |
|
matthieu-moy |
|
| 2006-09-02 03:55:38 |
John A Meinel |
bzr: statusexplanation |
Confirmed on the mailing-list. |
Mattheiu Moy has a pending fix for this. |
|
| 2006-09-02 03:55:54 |
John A Meinel |
bzr: status |
In Progress |
Fix Committed |
|
| 2006-09-02 03:55:54 |
John A Meinel |
bzr: statusexplanation |
Mattheiu Moy has a pending fix for this. |
|
|
| 2006-09-27 15:42:20 |
John A Meinel |
bzr: statusexplanation |
|
The fix is available, but needs some cleanup |
|
| 2006-10-23 16:48:37 |
John A Meinel |
bzr: statusexplanation |
The fix is available, but needs some cleanup |
The patch is still waiting in the queue to be properly reviewed for 0.13. |
|
| 2008-08-17 02:45:19 |
Matthew Fuller |
bzr: milestone |
0.13 |
|
|
| 2008-09-04 00:23:53 |
Mark Hammond |
bzr: status |
Fix Committed |
In Progress |
|
| 2008-09-04 00:23:53 |
Mark Hammond |
bzr: statusexplanation |
Milestone 0.13 for this is a sad joke. |
Here are John's latest comments from the mailing list - help in addressing these issues would be appreciated!
John Arbash Meinel has voted resubmit.
Status is now: Resubmit
Comment:
A few issues:
1) We need to have whitebox testing of WT.update in workingtree_implementations. This is updating the api to allow a 'revision' parameter, and we should make sure all implementations continue to do so.
2) We need a NEWS entry describing the API break (as plugins that implement a WT will now need to accept a revision in their update
function.)
3) You are using "revision[0].in_history(branch).rev_id" which should be replaced with "revision[0].as_revision_id(branch)". The latter is a newer function that doesn't have to do as much work in most cases.
4) This code still uses a form of "lookup the -r XXXX" in the local branch, and only if it can't be found look in the master branch. I feel like it should always be resolved in the master branch. That way "bzr update -r -1" is always the same as "bzr update". This was the crux of the discussion, IIRC, and why it wasn't merged way back when.
5) This is invasive enough that I don't really want it in 1.7, but I would be happy to see a cleaned up version merged into 1.8 as soon as it opens.
I didn't do a fully thorough trawl through the code, but that should be enough to refine this patch some more.
For details, see:
http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C01aa01c90a40%24b45d2e00%241d178a00%24%40com.au%3E
Project: Bazaar
|
|
| 2009-10-24 23:21:23 |
Aliaksei Vasileuski |
nominated for series |
|
bzr/2.1 |
|
| 2009-12-16 09:02:08 |
Andrew Bennetts |
bzr: importance |
Medium |
High |
|
| 2009-12-22 05:09:14 |
Martin Pool |
bzr: assignee |
Matthieu Moy (matthieu-moy) |
Martin Pool (mbp) |
|
| 2009-12-22 05:23:47 |
Martin Pool |
branch linked |
|
lp:~mbp/bzr/45719-update-r |
|
| 2010-01-07 06:00:07 |
Martin Pool |
bzr: status |
In Progress |
Fix Released |
|
| 2010-01-07 06:00:10 |
Martin Pool |
bug task added |
|
bzr/2.1 |
|
| 2010-01-07 06:00:09 |
Martin Pool |
bzr: milestone |
|
2.1.0rc1 |
|
| 2010-03-16 08:12:42 |
Matthew Fuller |
bzr/2.1: status |
New |
Fix Released |
|
| 2011-06-14 08:12:16 |
Max Bowsher |
removed subscriber Bazaar Developers |
|
|
|
