mutable_tree.has_changes() should not take a parameter but always check against basis
Bug #440631 reported by
Vincent Ladeuil
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
Medium
|
Vincent Ladeuil | ||
Bug Description
As discussed on IRC with jam.
Related branches
lp:~vila/bzr/440631-has-changes-no-param
- John A Meinel: Approve
-
Diff: 399 lines15 files modifiedNEWS (+11/-3)
bzrlib/builtins.py (+7/-6)
bzrlib/bundle/apply_bundle.py (+2/-1)
bzrlib/foreign.py (+1/-2)
bzrlib/merge.py (+10/-1)
bzrlib/mutabletree.py (+11/-3)
bzrlib/reconfigure.py (+1/-3)
bzrlib/send.py (+2/-3)
bzrlib/tests/blackbox/test_merge.py (+1/-1)
bzrlib/tests/blackbox/test_uncommit.py (+2/-2)
bzrlib/tests/test_msgeditor.py (+1/-1)
bzrlib/tests/test_mutabletree.py (+30/-9)
bzrlib/tests/test_reconfigure.py (+14/-1)
bzrlib/tests/test_status.py (+1/-1)
bzrlib/workingtree.py (+4/-4)
lp:~vila/bzr/integration
- Vincent Ladeuil: Approve
-
Diff: 31 lines (+4/-4)2 files modifiedbzrlib/lazy_regex.py (+3/-3)
doc/en/release-notes/bzr-2.7.txt (+1/-1)
| Changed in bzr: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Vincent Ladeuil (vila) wrote | #1 |
| Changed in bzr: | |
| milestone: | none → 2.1.0b1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The discussion with John was about has_changes() being used in several places in mostly the same way but with
differences with no good justifications.
This became more apparent with the addition of the --strict option to push, send, dpush, etc.
Some commands were doing some checks but roughly all the call sites wanted a way
to represent that the working tree has no changes worth committing.
All of them also always compare to their basis tree.
So during a review, John asked for a single method without parameter for all these use cases.