mutable_tree.has_changes() should not take a parameter but always check against basis

Bug #440631 reported by Vincent Ladeuil on 2009-10-02
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Medium
Vincent Ladeuil

Bug Description

As discussed on IRC with jam.

Related branches

Vincent Ladeuil (vila) on 2009-10-06
Changed in bzr:
status: Confirmed → Fix Committed
Vincent Ladeuil (vila) wrote :

The discussion with John was about has_changes() being used in several places in mostly the same way but with
differences with no good justifications.

This became more apparent with the addition of the --strict option to push, send, dpush, etc.
Some commands were doing some checks but roughly all the call sites wanted a way
to represent that the working tree has no changes worth committing.
All of them also always compare to their basis tree.

So during a review, John asked for a single method without parameter for all these use cases.

Vincent Ladeuil (vila) on 2009-10-07
Changed in bzr:
milestone: none → 2.1.0b1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers