John A Meinel wrote:
[...]
> A possible fix is to change the 'do I have enough inventories' logic, so that
> it checks the indexes in the entire repository, and not just the pack files
> being generated.
And looking at your original error report, it says:
“ValueError: We are missing inventories for revisions:”
Which is not an error from my new check (it would raise BzrCheckError, and
never uses that exact message). So I don't think my change is the culprit.
Instead it appears _copy_inventory_texts in GCCHKPacker is what's failing,
and at a glance it appears that indeed it assumes that the inventory for a
revision will be in the same set of packs being packed.
John A Meinel wrote:
[...]
> A possible fix is to change the 'do I have enough inventories' logic, so that
> it checks the indexes in the entire repository, and not just the pack files
> being generated.
Hmm, that's what it should be doing already:
etc.
And looking at your original error report, it says:
“ValueError: We are missing inventories for revisions:”
Which is not an error from my new check (it would raise BzrCheckError, and
never uses that exact message). So I don't think my change is the culprit.
Instead it appears _copy_inventory _texts in GCCHKPacker is what's failing,
and at a glance it appears that indeed it assumes that the inventory for a
revision will be in the same set of packs being packed.