poor message on lock contention

Bug #43521 reported by Martin Pool on 2006-05-08
4
Affects Status Importance Assigned to Milestone
Bazaar
Medium
John A Meinel

Bug Description

Hi. I pulled bzr.dev and bzr.0.8 at the same time, into the same
repository, and I got the following error message.

: [bagfors@zyrgelkwyt]$ ; bzr pull
Using saved location: http://bazaar-vcs.org/bzr/bzr.0.8/
bzr: ERROR: Could not acquire lock
LockDir(/home/bagfors/src/bzr/.bzr/repository/lock)
/home/bagfors/src/bzr/bzr.dev/bzrlib/lockable_files.py:107:
UserWarning: file group
LockableFiles(<bzrlib.transport.local.LocalTransport
url=/home/bagfors/src/bzr/bzr.0.8/.bzr/branch/>) was not explicitly
unlocked
 warn("file group %r was not explicitly unlocked" % self)
[Exit 3 ]

pulling again works...

I understand that there is a locking issue here, but I see two
problems with this
1) The error message is really bad. Will confuse a user

Related branches

John A Meinel (jameinel) wrote :

This is the current error:
liliana % bzr pull
Using saved location: sftp://juju//srv/bzr/public/branches/bzr/jam-integration/
bzr: ERROR: Could not acquire lock LockDir(file:///home/jameinel/dev/bzr/.bzr/repository/lock)

Do we still consider this to be a big bug?
Also, I have the 'wait-on-locks' branch outstanding, which would turn this into a message that bzr is going to start waiting on the lock, rather than an error that it cannot grab it yet.

Changed in bzr:
assignee: nobody → jameinel
status: Unconfirmed → Confirmed
John A Meinel (jameinel) wrote :

fix available in the associated branch. Unknown if it will be in 0.11 or 0.12

Changed in bzr:
status: Confirmed → Fix Committed
John A Meinel (jameinel) wrote :

Should get merged in 0.12, needs a little cleanup.

John A Meinel (jameinel) on 2006-10-11
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers