2.0.0rc2: error: Invalid value for commit message
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
John A Meinel | ||
2.0 |
Won't Fix
|
Low
|
John A Meinel |
Bug Description
Committing from Emacs on Windows XP produced a traceback complaining about the log message. The problem was the same either with utf-8 and windows-1252 encodings for the the log message.
Committing to: D:/dev/
modified var.h
modified var.cpp
modified backend.cpp
modified llvm.cpp
aborting commit write group: ValueError("Invalid value for commit message: u'llvm-cmds branch: Nueva variable\
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
ValueError: Invalid value for commit message: u'llvm-cmds branch: Nueva variable\
bzr 2.0.0rc2 on python 2.5.4 (Windows-
arguments: ['c:\\apps\
encoding: 'cp1252', fsenc: 'mbcs', lang: 'ESN'
plugins:
bzrtools C:\apps\
explorer C:\apps\
launchpad C:\apps\
netrc_
qbzr C:\apps\
rebase C:\apps\
svn C:\apps\
upload C:\apps\
xmloutput C:\apps\
*** Bazaar has encountered an internal error. This probably indicates a
bug in Bazaar. You can help us fix it by filing a bug report at
https:/
including this traceback and a description of the problem.
Related branches
- Vincent Ladeuil: Approve
-
Diff: 132 lines5 files modifiedNEWS (+38/-0)
bzr (+4/-0)
bzrlib/__init__.py (+4/-0)
bzrlib/builtins.py (+3/-0)
bzrlib/tests/blackbox/test_commit.py (+18/-0)
Changed in bzr: | |
status: | Fix Committed → Fix Released |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Oscar Fuentes wrote: idb-llvm/ lp0/ \r\\n`defstatic DestructorDestr oyer`. Necesaria porque la expresi\ \xf3n\\ r\\n`Commands: :DataDestroyer< DefstaticDestru ctor>` se resolv\\xeda a una\\r\\naddress diferente en el plugin LLVM cuando se compilaba en mingw,\ \r\\nproduciend o crashes en test cases que invocaban destructores de\\r\\ ndefstatics. \\r\\n' ",) ValueError: Invalid value for commit message: u'llvm-cmds branch: Nueva variable\ r\n`defstaticDe structorDestroy er`. Necesaria porque la expresi\ xf3n\r\ n`Commands: :DataDestroyer< DefstaticDestru ctor>` se resolv\xeda a una\r\naddress diferente en el plugin LLVM cuando se compilaba en mingw,\ r\nproduciendo crashes en test cases que invocaban destructores de\r\ndefstatic s.\r\n' commands. pyo", line 842, in exception_ to_return_ code commands. pyo", line 1037, in run_bzr commands. pyo", line 654, in run_argv_aliases builtins. pyo", line 3051, in run decorators. pyo", line 192, in write_locked workingtree_ 4.pyo", line 197, in commit decorators. pyo", line 192, in write_locked mutabletree. pyo", line 228, in commit commit. pyo", line 375, in commit repository. pyo", line 163, in commit repository. pyo", line 146, in _validate_ unicode_ text r\n`defstaticDe structorDestroy er`. Necesaria porque la expresi\ xf3n\r\ n`Commands: :DataDestroyer< DefstaticDestru ctor>` se resolv\xeda a una\r\naddress diferente en el plugin LLVM cuando se compilaba en mingw,\ r\nproduciendo crashes en test cases que invocaban destructores de\r\ndefstatic s.\r\n'
> Public bug reported:
>
> Committing from Emacs on Windows XP produced a traceback complaining
> about the log message. The problem was the same either with utf-8 and
> windows-1252 encodings for the the log message.
>
> Committing to: D:/dev/
> modified var.h
> modified var.cpp
> modified backend.cpp
> modified llvm.cpp
> aborting commit write group: ValueError("Invalid value for commit message: u'llvm-cmds branch: Nueva variable\
> bzr: ERROR: exceptions.
>
> Traceback (most recent call last):
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> File "bzrlib\
> ValueError: Invalid value for commit message: u'llvm-cmds branch: Nueva variable\
>
^- My guess is that the '\r\n' is being caught and rejected. We prefer
to have regular "\n" line endings. I'm not sure what code is passing
these in that isn't sanitizing them. Are you using a special emacs plugin?
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
3BM8ACgkQJdeBCY SNAAPRfACghUWCj 4TVd99OqPYwLYBt k6g4 2JT1gwzHug7tALb tGS26UD
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkq
/xcAn2YsE/
=LMjG
-----END PGP SIGNATURE-----