conflicting remember_remote_is_before() calls

[Radim Kolář]

After push, I changed just project tags (added 1 tag) and pushed again. It crashed with:

(hsn@ttyp0):~/sf/javalib% bzr push 22:03
Using saved push location: bzr+ssh://<email address hidden>/bzrroot/fsp/javalib/
bzr: ERROR: exceptions.AssertionError: _remember_remote_is_before((1, 18)) called, but _remember_remote_is_before((1, 13)) was called previously.

Traceback (most recent call last):
  File "/usr/local/lib/python2.5/site-packages/bzrlib/commands.py", line 835, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/commands.py", line 1030, in run_bzr
    ret = run(*run_argv)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/commands.py", line 647, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/builtins.py", line 1152, in run
    use_existing_dir=use_existing_dir)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/push.py", line 128, in _show_push_branch
    remember, create_prefix)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 1279, in push_branch
    overwrite, stop_revision=revision_id)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/branch.py", line 952, in push
    *args, **kwargs)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/branch.py", line 3101, in push
    _override_hook_source_branch=_override_hook_source_branch)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/branch.py", line 2917, in _run_with_write_locked_target
    result = callable(*args, **kwargs)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/branch.py", line 3140, in _push_with_bound_branches
    stop_revision)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/branch.py", line 2318, in _basic_push
    overwrite)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/tag.py", line 214, in merge_to
    to_tags._set_tag_dict(result)
  File "/usr/local/lib/python2.5/site-packages/bzrlib/tag.py", line 160, in _set_tag_dict
    return self.branch._set_tags_bytes(self._serialize_tag_dict(new_dict))
  File "/usr/local/lib/python2.5/site-packages/bzrlib/remote.py", line 2196, in _set_tags_bytes
    medium._remember_remote_is_before((1, 18))
  File "/usr/local/lib/python2.5/site-packages/bzrlib/smart/medium.py", line 607, in _remember_remote_is_before
    % (version_tuple, self._remote_version_is_before))
AssertionError: _remember_remote_is_before((1, 18)) called, but _remember_remote_is_before((1, 13)) was called previously.

bzr 1.18 on python 2.5.4 (freebsd6)
arguments: ['/usr/local/bin/bzr', 'push']
encoding: 'US-ASCII', fsenc: 'US-ASCII', lang: None
plugins:
  bzrtools /usr/local/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [1.18]
  cvs2bzr /home/hsn/.bazaar/plugins/cvs2bzr [unknown]
  gtk /usr/local/lib/python2.5/site-packages/bzrlib/plugins/gtk [0.97.0.final]
  launchpad /usr/local/lib/python2.5/site-packages/bzrlib/plugins/launchpad [1.18]
  netrc_credential_store /usr/local/lib/python2.5/site-packages/bzrlib/plugins/netrc_credential_store [1.18]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

repeating bzr push worked fine
(hsn@ttyp0):~/sf/javalib% bzr push 22:05
Using saved push location: bzr+ssh://<email address hidden>/bzrroot/fsp/javalib/
No new revisions to push.
(hsn@ttyp0):~/sf/javalib% 22:07

[Martin Pool (mbp)]

To me this is an inherent problem of remember_remote_is_before; we should talk instead about particular verbs or capabilities of the server and/or just look directly at the server's version.

[John A Meinel (jameinel)]

I don't doubt we have a capability issue here, but I think there is also a specific bug. Namely, _set_tags_bytes is probably not verifying what version the server is before it issues a request.

[Andrew Bennetts (spiv)]

This is a dupe of #418931, which was fixed in 1.18.1.