test suite regression on OSX and FreeBSD

Bug #433120 reported by Vincent Ladeuil on 2009-09-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Medium
Vincent Ladeuil

Bug Description

No name to protect the innocents, but some new code forgot about some known issues:
- OSX silently redirect /tmp to /private/tmp
- OSX and FreeBSD doesn't raise the same exception than Linux when os.remove() is used for a dir

Related branches

Vincent Ladeuil (vila) on 2009-09-19
Changed in bzr:
assignee: nobody → Vincent Ladeuil (vila)
importance: Undecided → Medium
status: New → In Progress
status: In Progress → Fix Committed
milestone: none → 2.1.0b1

On Sat, 2009-09-19 at 22:51 +0000, Vincent Ladeuil wrote:
> For historical reasons:
>
> FreeBSD: FAILED (errors=2, known_failure_count=29)
> http://babune.ladeuil.net:26862/builders/freebsd7/builds/7/steps/Non-regression%20tests/logs/stdio
> http://babune.ladeuil.net:26862/builders/freebsd8/builds/7/steps/Non-regression%20tests/logs/stdio

^^^^[log from
bzrlib.tests.test_script.TestRm.test_rm_dir]--------------------
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/test_script.py", line 404, in test_rm_dir
    """)
  File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/script.py", line 405, in run_script
    return self.script_runner.run_script(script)
  File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/script.py", line 169, in run_script
    self.run_command(cmd, input, output, error)
  File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/script.py", line 219, in run_command
    retcode, actual_output, actual_error = method(str_input, args)
  File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/script.py", line 350, in do_rm
    os.remove(p)
OSError: [Errno 1] Operation not permitted: 'dir'

Seems different :)

Vincent Ladeuil (vila) wrote :

>>>>> "robert" writes:

    robert> On Sat, 2009-09-19 at 22:51 +0000, Vincent Ladeuil wrote:
    >> For historical reasons:
    >>
    >> FreeBSD: FAILED (errors=2, known_failure_count=29)
    >> http://babune.ladeuil.net:26862/builders/freebsd7/builds/7/steps/Non-regression%20tests/logs/stdio
    >> http://babune.ladeuil.net:26862/builders/freebsd8/builds/7/steps/Non-regression%20tests/logs/stdio

    robert> ^^^^[log from
    robert> bzrlib.tests.test_script.TestRm.test_rm_dir]--------------------
    robert> ----------------------------------------------------------------------
    robert> Traceback (most recent call last):
    robert> File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/test_script.py", line 404, in test_rm_dir
    robert> """)
    robert> File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/script.py", line 405, in run_script
    robert> return self.script_runner.run_script(script)
    robert> File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/script.py", line 169, in run_script
    robert> self.run_command(cmd, input, output, error)
    robert> File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/script.py", line 219, in run_command
    robert> retcode, actual_output, actual_error = method(str_input, args)
    robert> File "/usr/home/babune/buildbot/bzr/slaves/freebsd8/tests/freebsd8/build/bzrlib/tests/script.py", line 350, in do_rm
    robert> os.remove(p)
    robert> OSError: [Errno 1] Operation not permitted: 'dir'

    robert> Seems different :)

If you want to look at the test isolation escapes, search the OSX
logs, the FreeBSD ones are only about remove raising EACCESS
where EISDIR was expected.

Vincent Ladeuil (vila) on 2009-09-20
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers