'diff in a lightweight checkout' prompts for the password multiple times

[John A Meinel]

This might be a qbzr bug, but when doing: "Diff" in a lightweight checkout, it prompts me for my password 2 times. Presumably it isn't caching the connection to the branch, and thus re-opening it to get the content of both the current and target revision.

[Alexander Belchenko (bialix)]

Does plain bzr diff works differently? Do you have any ideas why?

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Does plain bzr diff works differently? Do you have any ideas why?
>
> ** Changed in: qbzr
> Status: New => Incomplete
>

'bzr diff' gives a single login.
'bzr qdiff' gives two logins

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqw7bMACgkQJdeBCYSNAAM1iwCgv8mTGHnsikH3Syh0jZ3je4dx
yk4AoJJk5jBFE2d7YXUPCGoeMrNV8zEh
=/9jN
-----END PGP SIGNATURE-----

[Alexander Belchenko (bialix)]

I think we ought to fix it and we should think about password caching technique to help bzr-explorer problems too.

[Gary van der Merwe (garyvdm)]

To fix this, we need to change bzrlib.diff._get_trees_to_diff to also return the old and new branches.

Then bzrlib.plugins.qbzr.lib.commands.cmd_qdiff.get_diff_window_args won't need to open them separately.

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> To fix this, we need to change bzrlib.diff._get_trees_to_diff to also
> return the old and new branches.

I think you mean old and new trees, not branches?

> Then bzrlib.plugins.qbzr.lib.commands.cmd_qdiff.get_diff_window_args
> won't need to open them separately.

So, this bug is not in qbzr?

[Gary van der Merwe (garyvdm)]

On Fri, Sep 18, 2009 at 3:50 PM, Alexander Belchenko <email address hidden> wrote:
> I think you mean old and new trees, not branches?

It currently returns the old and new trees. We need to change it to
also return the old and new branches.

> So, this bug is not in qbzr?

No, but the fix starts with a change in bzrlib.

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> On Fri, Sep 18, 2009 at 3:50 PM, Alexander Belchenko <email address hidden> wrote:
>> I think you mean old and new trees, not branches?
>
> It currently returns the old and new trees. We need to change it to
> also return the old and new branches.

Is not tree.branch is what you need?

[Gary van der Merwe (garyvdm)]

On Fri, Sep 18, 2009 at 4:24 PM, Alexander Belchenko <email address hidden> wrote:
> Is not tree.branch is what you need?

That is only available from WorkingTree, not RevisionTree

[Alexander Belchenko (bialix)]

Gary van der Merwe пишет:
> On Fri, Sep 18, 2009 at 4:24 PM, Alexander Belchenko <email address hidden> wrote:
>> Is not tree.branch is what you need?
>
> That is only available from WorkingTree, not RevisionTree

Hmmm....

[Gary van der Merwe (garyvdm)]

Note that this will only be fixed when using bzr >= 2.1.