Doesn't recognize non-email addresses in <>

[John A Meinel]

I was playing around with setting up users without full email addresses, as it isn't really needed in a corporate setting.

As such I entered:

Username: Good User
Email: guser

And that creates a "whoami" of
Good User <guser>

When you go back to the config entry, you end up with:

Username: Good User <guser>
Email:

(email box is empty)

I'm guessing the regex should be changed to just pick anything in <> rather than requiring the @ symbol.

[Alexander Belchenko (bialix)]

qconfig using extract_email_address from bzrlib/config.py therefore this is bug in bzrlib.

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> qconfig using extract_email_address from bzrlib/config.py therefore this
> is bug in bzrlib.
>
> ** Project changed: qbzr => bzr
>

 project qbzr

My point is that you probably don't want "extract_email_address" as
these aren't valid email addresses.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqw5OUACgkQJdeBCYSNAAMFOgCgoqHrKgMRLhnxygYERcIhCvcC
GqQAnixnucKgRytQzRZeQvPwRLS4CeK3
=Bbov
-----END PGP SIGNATURE-----

[Alexander Belchenko (bialix)]

If this is no e-mail address then I doubt we should show it under E-mail section. Why for you need to specify something inside <>? Is not bzr should support the work without such address?

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> If this is no e-mail address then I doubt we should show it under E-mail
> section. Why for you need to specify something inside <>? Is not bzr
> should support the work without such address?
>

The specific request here was to use the user's standard username. So
they would give eg "jameinel" in that field.

My main complaint is that QBzr's config dialog isn't round-tripping the
information. I type:

Username: John Meinel
Email: jameinel

And I get back

Username: John Meinel <jameinel>
Email:

We could either:

1) Check and refuse things that don't look like an email address added
to the email field
2) Change internal bzr to return anything that is in <> as an "email"
3) Have a custom function in qbzr that does the same thing as (2)
instead of the bzr function.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqxKDEACgkQJdeBCYSNAAMA7QCeMsRaSx/kDgCUuHabqw5K9npM
A5IAoJQAVh7xqAurXtmFMmKnJQUi/u+5
=A+7D
-----END PGP SIGNATURE-----

[Alexander Belchenko (bialix)]

I think round-tripping is important.