bzrlib.errors.ObjectNotLocked error while logging a remote branch

[Jonathan Lange]

$ bzr log -v -r-1 lp:~jml/bzr/prepare-1.17
bzr: ERROR: bzrlib.errors.ObjectNotLocked: _KnitGraphIndex(CombinedGraphIndex()) is not locked

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 835, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 1030, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 647, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 1045, in ignore_pipe
    result = func(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/builtins.py", line 2276, in run
    file_list)
  File "/usr/lib/python2.6/dist-packages/bzrlib/log.py", line 1866, in _get_info_for_log_files
    "log")
  File "/usr/lib/python2.6/dist-packages/bzrlib/builtins.py", line 2365, in _get_revision_range
    rev1 = rev2 = revisionspec_list[0].in_history(branch)
  File "/usr/lib/python2.6/dist-packages/bzrlib/revisionspec.py", line 225, in in_history
    return self._match_on_and_check(branch, revs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/revisionspec.py", line 204, in _match_on_and_check
    info = self._match_on(branch, revs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/revisionspec.py", line 320, in _match_on
    branch, revno, revision_id = self._lookup(branch, revs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/revisionspec.py", line 380, in _lookup
    revision_id = branch.get_rev_id(revno, revs_or_none)
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 2271, in get_rev_id
    revno, last_revision_info)
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 696, in get_rev_id_for_revno
    return self._get_rev_id_for_revno_vfs(revno, known_pair)
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 684, in _get_rev_id_for_revno_vfs
    revno, known_pair)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 2269, in get_rev_id_for_revno
    self, partial_history, stop_index=distance_from_known)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 4370, in _iter_for_revno
    iterator.next()
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 2299, in iter_reverse_revision_history
    parents = graph.get_parent_map([next_id])[next_id]
  File "/usr/lib/python2.6/dist-packages/bzrlib/graph.py", line 167, in get_parent_map
    parent_map = self._get_parent_map(needed_revisions)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 2457, in get_parent_map
    self.revisions.get_parent_map(query_keys).iteritems():
  File "/usr/lib/python2.6/dist-packages/bzrlib/knit.py", line 1193, in get_parent_map
    return self._get_parent_map_with_sources(keys)[0]
  File "/usr/lib/python2.6/dist-packages/bzrlib/knit.py", line 1212, in _get_parent_map_with_sources
    new_result = source.get_parent_map(missing)
  File "/usr/lib/python2.6/dist-packages/bzrlib/knit.py", line 3047, in get_parent_map
    self._check_read()
  File "/usr/lib/python2.6/dist-packages/bzrlib/knit.py", line 2930, in _check_read
    raise errors.ObjectNotLocked(self)
ObjectNotLocked: _KnitGraphIndex(CombinedGraphIndex()) is not locked

bzr 1.18dev on python 2.6.2 (linux2)
arguments: ['/usr/bin/bzr', 'log', '-v', '-r-1', 'lp:~jml/bzr/prepare-1.17']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_AU.UTF-8'
plugins:
  bzrtools /home/jml/.bazaar/plugins/bzrtools [1.17]
  difftodo /home/jml/.bazaar/plugins/difftodo [unknown]
  imapclient /home/jml/.bazaar/plugins/imapclient [unknown]
  launchpad /usr/lib/python2.6/dist-packages/bzrlib/plugins/launchpad [1.18dev]
  loom /home/jml/.bazaar/plugins/loom [1.4dev]
  lpreview /home/jml/.bazaar/plugins/lpreview [unknown]
  netrc_credential_store /usr/lib/python2.6/dist-packages/bzrlib/plugins/netrc_credential_store [1.18dev]
  ping /home/jml/.bazaar/plugins/ping [unknown]
  pipeline /home/jml/.bazaar/plugins/pipeline [unknown]
  pqm /home/jml/.bazaar/plugins/pqm [1.4dev]
  pqmstats /home/jml/.bazaar/plugins/pqmstats.py [unknown]
  stats /home/jml/.bazaar/plugins/stats [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.
HPSS calls: 17 (6 vfs) SmartSSHClientMedium(connected=False, username=u'jml', host='bazaar.launchpad.net', port=None)

[Levi Bard (taktaktaktaktaktaktaktaktaktak)]

I also get this error 100% of the time when logging with a revspec on foreign (bzr-svn, bzr-git) branches.

> bzr log -r 0.. ChangeLog
bzr: ERROR: bzrlib.errors.ObjectNotLocked: <bzrlib.groupcompress._GCGraphIndex object at 0x9d4e82c> is not locked

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 842, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 1037, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 654, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 1052, in ignore_pipe
    result = func(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 2280, in run
    file_list)
  File "/usr/lib/python2.5/site-packages/bzrlib/log.py", line 1911, in _get_info_for_log_files
    kind = _get_kind_for_file_id(tree, file_id)
  File "/usr/lib/python2.5/site-packages/bzrlib/log.py", line 1929, in _get_kind_for_file_id
    return tree.kind(file_id)
  File "/usr/lib/python2.5/site-packages/bzrlib/revisiontree.py", line 148, in kind
    return self._inventory[file_id].kind
  File "/usr/lib/python2.5/site-packages/bzrlib/inventory.py", line 2008, in __getitem__
    self.id_to_entry.iteritems([(file_id,)]).next()[1])
  File "/usr/lib/python2.5/site-packages/bzrlib/chk_map.py", line 484, in iteritems
    self._ensure_root()
  File "/usr/lib/python2.5/site-packages/bzrlib/chk_map.py", line 138, in _ensure_root
    self._root_node = self._get_node(self._root_node)
  File "/usr/lib/python2.5/site-packages/bzrlib/chk_map.py", line 151, in _get_node
    bytes = self._read_bytes(node)
  File "/usr/lib/python2.5/site-packages/bzrlib/chk_map.py", line 162, in _read_bytes
    bytes = stream.next().get_bytes_as('fulltext')
  File "/usr/lib/python2.5/site-packages/bzrlib/groupcompress.py", line 1423, in get_record_stream
    orig_keys, ordering, include_delta_closure):
  File "/usr/lib/python2.5/site-packages/bzrlib/groupcompress.py", line 1528, in _get_remaining_record_stream
    locations = self._index.get_build_details(keys)
  File "/usr/lib/python2.5/site-packages/bzrlib/groupcompress.py", line 2002, in get_build_details
    self._check_read()
  File "/usr/lib/python2.5/site-packages/bzrlib/groupcompress.py", line 1922, in _check_read
    raise errors.ObjectNotLocked(self)
ObjectNotLocked: <bzrlib.groupcompress._GCGraphIndex object at 0x9d4e82c> is not locked

bzr 2.0.1 on python 2.5.4 (Linux-2.6.30-2-686-i686-with-debian-squeeze-sid)
arguments: ['/usr/bin/bzr', 'log', '-r', '0..', 'ChangeLog']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  bzrtools /usr/lib/python2.5/site-packages/bzrlib/plugins/bzrtools [2.0.1]
  git /usr/lib/python2.5/site-packages/bzrlib/plugins/git [0.4.1]
  hg /usr/lib/python2.5/site-packages/bzrlib/plugins/hg [0.1.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [2.0.1]
  netrc_credential_store /usr/lib/python2.5/site-packages/bzrlib/plugins/netrc_cre...

[John A Meinel (jameinel)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Levi Bard wrote:
> I also get this error 100% of the time when logging with a revspec on
> foreign (bzr-svn, bzr-git) branches.
>
>> bzr log -r 0.. ChangeLog
> bzr: ERROR: bzrlib.errors.ObjectNotLocked: <bzrlib.groupcompress._GCGraphIndex object at 0x9d4e82c> is not locked
>

That can't be a foreign branch. Perhaps it as Bazaar conversion of a
foreign branch, but foreign branches will never have a "_GCGraphIndex".

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrpuLIACgkQJdeBCYSNAAP5kACglp8jXGrC+pWIWAciIE4K7LUz
h/kAnRv+AjCNFrobh1sTjb1L4A3Dye/V
=ixYR
-----END PGP SIGNATURE-----

[Andrew Bennetts (spiv)]

Levi, your problem is bug 445171, which co-incidentally was fixed yesterday. The 2.0.2 and 2.1.0b2 releases should include that fix.

The original bug report was probably a dupe of bug 389413, so I'm marking it as such. Certainly I can't reproduce it anymore.