ChrootServer/ChrootTransport not used by "bzr serve"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Critical
|
Andrew Bennetts | ||
Bug Description
bzrlib/
chroot_server = ChrootServer(
chroot_
t = get_transport(
But it then fails to use either chroot_server or t. Instead it runs the server with 'transport', which is generally a file:/// URL.
This may be the cause of bug 398199.
It certainly breaks some trivial uses of bzr serve. A server set up like this:
$ mkdir /tmp/test-area
$ cd /tmp/test-area
$ bzr serve --allow-writes
Will not behave correctly:
$ bzr --no-plugins init bzr://localhost
bzr: ERROR: Server sent an unexpected error: ('error', "An attempt to access a url outside the server jail was made: 'file:///tmp/'.")
HPSS calls: 7 (2 vfs) <bzrlib.
This should be fixed for 1.17.
Related branches
- Robert Collins (community): Approve
- Diff: 162 lines
Changed in bzr: | |
status: | Fix Committed → Fix Released |
I have a fix, tests still to come.