Bundle (bzr send) broken with --2a format
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Critical
|
John A Meinel |
Bug Description
It turns out that the code that generates bundles is broken wrt --2a format repositories.
When it generates data to put into the bundle it reads the raw inventory texts from the repository, and inserts them into the bundle. But it does *not* include any chk pages. This means that the real "inventory" data is completely unavailable in the generated bundle. We don't discover this until we try to insert the bundle into another repository and then find that we can't read any of the chk pages.
Options:
1) Instead of using "inventories.
2) Teach the bundle code that after generating an mp_diff of the inventory, it needs to go find the chk pages and include them as well.
I originally thought this was about stacking, but it isn't. The data about tree shape just isn't present in the bundles generated from a --2a repository.
I'm leaving the traceback since that may help people who run into this find the bug.
> bzr pull ../my.patch
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\diff.pyo", line 427, in show_diff_trees
File "bzrlib\diff.pyo", line 834, in show_diff
File "bzrlib\diff.pyo", line 857, in _show_diff
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
AttributeError: 'AbsentContentF
bzr 1.16.1 on python 2.5.2 (win32)
arguments: ['C:\\Program Files\\
encoding: 'cp1251', fsenc: 'mbcs', lang: None
plugins:
bzrtools C:\Program Files\Bazaar\
docdiff C:\Program Files\Bazaar\
launchpad C:\Program Files\Bazaar\
netrc_
qbzr C:\Program Files\Bazaar\
rebase C:\Program Files\Bazaar\
svn C:\Program Files\Bazaar\
*** Bazaar has encountered an internal error.
Please report a bug at https:/
including this traceback, and a description of what you
were doing when the error occurred.
Related branches
- Martin Pool: Approve
- Diff: 0 lines
Changed in bzr: | |
milestone: | none → 2.0 |
summary: |
- exceptions.AttributeError: 'AbsentContentFactory' object has no - attribute 'get_bytes_as' + Bundles broken with --2a format |
description: | updated |
summary: |
- Bundles broken with --2a format + Bundle (bzr send) broken with --2a format |
Changed in bzr: | |
status: | Triaged → In Progress |
We're also getting this error on Launchpad, see OOPS-1283SMPU324 for example.