No need to report protocol in progress bar line

[Andrew Cowie]

Given that the first thing that commands like `bzr pull` do when executed is report the branch URL they are reading from, and that URL includes a protocol component, there doesn't seem much reason to consume 8 or so characters on the progress bar line saying what the protocol is.

These extra characters could then be given to the part of the line where it says what Bazaar is actually doing.

AfC

[Martin Pool (mbp)]

I agree.

[Robert Collins (lifeless)]

On Mon, 2009-05-18 at 03:20 +0000, Andrew Cowie wrote:
> Public bug reported:
>
> Given that the first thing that commands like `bzr pull` do when
> executed is report the branch URL they are reading from, and that URL
> includes a protocol component, there doesn't seem much reason to
> consume 8 or so characters on the progress bar line saying what the
> protocol is.
>
> These extra characters could then be given to the part of the line where
> it says what Bazaar is actually doing.

Operations will commonly talk to multiple resources that are often on
different protocols. Arguably we should be showing the host as well, or
even the url.

-Rob

[Andrew Cowie (afcowie)]

Ok, so how about a multi (2?) line progress area, perhaps

------
$ bzr pull
bzr://research.operationaldynamics.com/bzr/slashtime/mainline
376KB 94KB/s | Fetching revisions:Insert [and I would love to know the rest but it was truncated]
------

or better yet, put the progress at the right hand side like most other tools do:

------
$ bzr pull
bzr://research.operationaldynamics.com/bzr/slashtime/mainline
Fetching revisions:Insert, and I now know more details excep... | 376KB 94KB/s
------

Also illustrating a different truncating behaviour for you to contemplate.

AfC

[Martin Pool (mbp)]

2-line progress bars may be a bit harder to draw portably, but it may
be a good option.

I'm inclined to think we should show 'connecting to
bzr+ssh://blah/....' as a distinct message while it's happening and
that will help.

--
Martin <http://launchpad.net/~mbp/>

[Martin Pool (mbp)]

This was fixed a while ago