WorkingTree.walkdirs() has file_kind twice in tuple

[Chris Lasher]

WorkingTree, found in bzrlibs.workingtree, has a method called walkdirs(). The docstring of this method states:

        returns a generator which yields items in the form:
                ((curren_directory_path, fileid),
                 [(file1_path, file1_name, file1_kind, (lstat), file1_id,
                   file1_kind), ... ])

Why is file_kind presented twice (at indices [1][:][2] and [1][:][5])? Shouldn't it just appear once?

[Robert Collins (lifeless)]

On Thu, 2009-04-30 at 06:03 +0000, Chris Lasher wrote:
> Public bug reported:
>
> WorkingTree, found in bzrlibs.workingtree, has a method called
> walkdirs(). The docstring of this method states:
>
> returns a generator which yields items in the form:
> ((curren_directory_path, fileid),
> [(file1_path, file1_name, file1_kind, (lstat), file1_id,
> file1_kind), ... ])
>
> Why is file_kind presented twice (at indices [1][:][2] and [1][:][5])?
> Shouldn't it just appear once?

It mirrors a deeper API for walking dirs that reports on 'versioned
kind' and 'actual kind'.

The docstring could be clearer.

 status confirmed
 importance low