WorkingTree.walkdirs() has file_kind twice in tuple

Bug #369667 reported by Chris Lasher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Low
Unassigned

Bug Description

WorkingTree, found in bzrlibs.workingtree, has a method called walkdirs(). The docstring of this method states:

        returns a generator which yields items in the form:
                ((curren_directory_path, fileid),
                 [(file1_path, file1_name, file1_kind, (lstat), file1_id,
                   file1_kind), ... ])

Why is file_kind presented twice (at indices [1][:][2] and [1][:][5])? Shouldn't it just appear once?

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 369667] [NEW] WorkingTree.walkdirs() has file_kind twice in tuple

On Thu, 2009-04-30 at 06:03 +0000, Chris Lasher wrote:
> Public bug reported:
>
> WorkingTree, found in bzrlibs.workingtree, has a method called
> walkdirs(). The docstring of this method states:
>
> returns a generator which yields items in the form:
> ((curren_directory_path, fileid),
> [(file1_path, file1_name, file1_kind, (lstat), file1_id,
> file1_kind), ... ])
>
> Why is file_kind presented twice (at indices [1][:][2] and [1][:][5])?
> Shouldn't it just appear once?

It mirrors a deeper API for walking dirs that reports on 'versioned
kind' and 'actual kind'.

The docstring could be clearer.

 status confirmed
 importance low

Changed in bzr:
importance: Undecided → Low
status: New → Confirmed
Jelmer Vernooij (jelmer)
tags: added: apidoc workingtree
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.