EDITOR environmental variable cannot be path surrounded by quotes. Bad error message.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Confirmed
|
Low
|
Unassigned |
Bug Description
This has only been tested on windows.
bazaar v1.13
If the value of the EDITOR environmental variable is a path surrounded by quotes, commit will fail.
The error message given is not useful.
At the very least a error should be given stating the value of EDITOR is not valid.
Here is the terminal output.
Here three attempts are tried:
1. EDITOR set to valid path, but with quotes.
2. EDITOR set in invalid path, no quotes.
3. EDITOR set to valid path, no quotes.
=======
>
>
>set EDITOR=
>echo %EDITOR%
"C:\Programs\
>bzr commit
Committing to: C:/library/
modified README
aborting commit write group: WindowsError(123, 'The filename, directory name, or volume label syntax is incorrect')
bzr: ERROR: [Error 123] The filename, directory name, or volume label syntax is incorrect
>
>
>set EDITOR=
>echo %EDITOR%
C:\Programs\
>bzr commit
Committing to: C:/library/
modified README
Could not start editor "C:\Programs\
nnot find the file specified
aborting commit write group: BzrCommandError
bzr: ERROR: empty commit message specified
>
>
>set EDITOR=
>echo %EDITOR%
C:\Programs\
>bzr commit
Committing to: C:/library/
modified README
aborting commit write group: BzrCommandError
bzr: ERROR: empty commit message specified
>
Entry in .bzr.log:
============
Sun 2009-04-26 15:30:59 -0700
0.203 bzr arguments: [u'commit']
0.234 looking for plugins in C:/home/
0.234 looking for plugins in C:/Programs/
0.531 encoding stdout as sys.stdout encoding 'cp437'
0.625 opening working tree 'C:/library/
0.656 preparing to commit
[13436] 2009-04-26 15:30:59.703 INFO: Committing to: C:/library/
0.703 Selecting files for commit with filter []
[13436] 2009-04-26 15:30:59.733 INFO: modified README
0.875 check paths: None
0.906 aborting commit write group because of exception:
0.906 Traceback (most recent call last):
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "subprocess.pyo", line 444, in call
File "subprocess.pyo", line 594, in __init__
File "subprocess.pyo", line 816, in _execute_child
WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect
[13436] 2009-04-26 15:30:59.905 INFO: aborting commit write group: WindowsError(123, 'The filename, directory name, or v
olume label syntax is incorrect')
1.078 Traceback (most recent call last):
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "bzrlib\
File "subprocess.pyo", line 444, in call
File "subprocess.pyo", line 594, in __init__
File "subprocess.pyo", line 816, in _execute_child
WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect
1.078 return code 3
Changed in bzr: | |
importance: | Undecided → Low |
status: | New → Triaged |
tags: | added: win32 |
Changed in bzr: | |
status: | Triaged → Confirmed |
tags: | added: check-for-breezy |