No way to ask bzrlib to close an SFTP connection

[Andrew Bennetts]

When writing a test for something involving bzr and an SFTP server, I had a need to close an SFTP connection (to force the next branch open to open a new connection). bzrlib offers no facility for this that I can see, apart from "bzrlib.transport.sftp._connected_hosts.clear()", which is clearly not supported :)

I can imagine other users of bzrlib may need to control this as well.

[Jonathan Lange (jml)]

Well, now it provides 'clear_connection_cache()', but that's still not quite enough.

[Jonathan Lange (jml)]

Apr 18 14:09:13 <lifeless> bzrlib/transport/remote.py has a disconnect method
Apr 18 14:09:26 <lifeless> if you add one to sftp.py that would be nice.
Apr 18 14:09:36 <lifeless> perhaps at the base class, with a no-op.
Apr 18 14:09:40 <lifeless> docstring
...
Apr 18 14:16:24 <jml> lifeless: by 'at the base class', which class do you mean exactly?
Apr 18 14:16:33 <lifeless> Transport

[Vincent Ladeuil (vila)]

The fixes related to the leaking tests as landed in 2.3b1 and they introduced a disconnect() method implemented for SFTPTransport.