Push should have an option to not stack

Bug #331288 reported by Jonathan Lange
2
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Undecided
Unassigned

Bug Description

Some servers, notably Launchpad, provide default stacked-on policies which encourage all new branches in an area to be stacked on a server-configured branch.

Sometimes, people pushing up branches will need to override that policy and say, no, this branch should not be stacked on anything. Bazaar currently does not provide a way to do this. It should. 'bzr push --not-stacked' perhaps?

Vincent Ladeuil (vila)
Changed in bzr:
status: New → Incomplete
Revision history for this message
Vincent Ladeuil (vila) wrote :

That should already work using '--no-stacked' instead of '--not-stacked'

Revision history for this message
Jonathan Lange (jml) wrote :

Ahhh, I see, implicit option negation.

In that case, the bug is that it's too hard to figure this out from looking at push help. Because the decision to stack isn't made entirely on the client, --no-stacked needs to be mentioned explicitly in the help. Please feel free to change the bug description.

Revision history for this message
John A Meinel (jameinel) wrote :

Did you try it and see if it worked? I wouldn't be surprised if "no-stacked" is the default, and a "implicit" stacking directive from Launchpad actually overrides it.
Looking at the code fairly closely I see:
def run(self, location=None, remember=False, overwrite=False,
    create_prefix=False, verbose=False, revision=None,
    use_existing_dir=False, directory=None, stacked_on=None,
    stacked=False):

So I'm pretty sure "bzr push --no-stacked" won't do anything. The only chance it would have is if "stacked=None" which allowed us to detect the difference between "--no-stacked" and no option being passed.

Revision history for this message
Jonathan Lange (jml) wrote : Re: [Bug 331288] Re: Push should have an option to not stack

On Fri, Feb 20, 2009 at 9:20 AM, John A Meinel <email address hidden> wrote:
> Did you try it and see if it worked? I wouldn't be surprised if "no-stacked" is the default, and a "implicit" stacking directive from Launchpad actually overrides it.

No I didn't! This is a use-case that I don't have much of a personal stake in.

> Looking at the code fairly closely I see:
> def run(self, location=None, remember=False, overwrite=False,
> create_prefix=False, verbose=False, revision=None,
> use_existing_dir=False, directory=None, stacked_on=None,
> stacked=False):
>
> So I'm pretty sure "bzr push --no-stacked" won't do anything. The only
> chance it would have is if "stacked=None" which allowed us to detect the
> difference between "--no-stacked" and no option being passed.
>

In which case, the original bug stands: Bazaar needs a way of
overriding the server's hints.

jml

Revision history for this message
Vincent Ladeuil (vila) wrote :

So I guess it's confirmed.

It's shame I was doing too much things at once when I failed to push a branch (can't remember which but one on launchpad) and re-trying with push --no-stacked succeeded...

Sorry for the confusion.

Changed in bzr:
status: Incomplete → Confirmed
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.