TooManyConcurrentRequests when committing and the smart server is offline

[Grant Rettke]

When committing against a bzr checked out branch against a smart server that is offline, the following error is displayed:

bzr: ERROR: bzrlib.errors.TooManyConcurrentRequests: The medium '<bzrlib.smart.m
edium.SmartTCPClientMedium object at 0x0181E5D0>' has reached its concurrent req
uest limit. Be sure to finish_writing and finish_reading on the currently open r
equest.

Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 893, in run_bzr_catch_errors
  File "bzrlib\commands.pyo", line 839, in run_bzr
  File "bzrlib\commands.pyo", line 539, in run_argv_aliases
  File "bzrlib\builtins.pyo", line 2502, in run
  File "bzrlib\decorators.pyo", line 192, in write_locked
  File "bzrlib\workingtree_4.pyo", line 224, in commit
  File "bzrlib\decorators.pyo", line 192, in write_locked
  File "bzrlib\mutabletree.pyo", line 208, in commit
  File "bzrlib\commit.pyo", line 300, in commit
  File "bzrlib\commit.pyo", line 462, in _check_bound_branch
  File "bzrlib\decorators.pyo", line 138, in read_locked
  File "bzrlib\branch.pyo", line 1990, in get_master_branch
  File "bzrlib\branch.pyo", line 123, in open
  File "bzrlib\bzrdir.pyo", line 778, in open
  File "bzrlib\bzrdir.pyo", line 811, in open_from_transport
  File "bzrlib\bzrdir.pyo", line 1756, in open
  File "bzrlib\bzrdir.pyo", line 2657, in _open
  File "bzrlib\remote.pyo", line 93, in __init__
  File "bzrlib\remote.pyo", line 51, in _call
  File "bzrlib\smart\client.pyo", line 122, in call
  File "bzrlib\smart\client.pyo", line 135, in call_expecting_body
  File "bzrlib\smart\client.pyo", line 80, in _call_and_read_response
  File "bzrlib\smart\client.pyo", line 42, in _send_request
  File "bzrlib\smart\client.pyo", line 105, in _construct_protocol
  File "bzrlib\smart\medium.pyo", line 672, in get_request
  File "bzrlib\smart\medium.pyo", line 870, in __init__
TooManyConcurrentRequests: The medium '<bzrlib.smart.medium.SmartTCPClientMedium
 object at 0x0181E5D0>' has reached its concurrent request limit. Be sure to fin
ish_writing and finish_reading on the currently open request.

bzr 1.11 on python 2.5.2 (win32)
arguments: ['bzr', 'commit', '-m', 'Refactored out the creation of a dot in draw
-maps and overlap']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [1.11]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [unknown]
  netrc_credential_store C:\Program Files\Bazaar\plugins\netrc_credential_store
[unknown]
  qbzr C:\Program Files\Bazaar\plugins\qbzr [0.9.6]
  svn C:\Program Files\Bazaar\plugins\svn [0.4.17]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

The server is:

Bazaar (bzr) 1.9
 Python interpreter: C:\Program Files\Bazaar\python25.dll 2.5.2
 Python standard library: C:\Program Files\Bazaar\lib\library.zip
 bzrlib: C:\Program Files\Bazaar\lib\library.zip\bzrlib
 Bazaar configuration: C:\Users\grettke\AppData\Roaming\bazaar\2.0
 Bazaar log file: C:\Users\grettke\Documents\.bzr.log

Copyright 2005, 2006, 2007, 2008 Canonical Ltd.
http://bazaar-vcs.org/

bzr comes with ABSOLUTELY NO WARRANTY. bzr is free software, and
you may use, modify and redistribute it under the terms of the GNU
General Public License version 2 or later.

I am reporting this because it seems that the issue was that the server was unavailable, as once I started it the commit worked fine.

However, at first glance, it would seems as though it was a bug.

[Robert Collins (lifeless)]

Ack, this is confusing. Bumping to high because we really need to get these stomped out.

[John Ferlito (johnf-inodes)]

I'm seeing something similar.

Server: 1.13
Client: 1.14.1
Protocol: bzr://

In my case it happens when my VPN is down and my upstream sends back Admin Prohibited packets.

Backtrace:

bzr: ERROR: bzrlib.errors.TooManyConcurrentRequests: The medium '<bzrlib.smart.medium.SmartTCPClientMedium object at 0x949aa8c>' has reached its concurrent request limit. Be sure to finish_writing and finish_reading on the currently open request.

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 727, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 922, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 559, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.6/dist-packages/bzrlib/builtins.py", line 2878, in run
    exclude=safe_relpath_files(tree, exclude))
  File "/usr/lib/python2.6/dist-packages/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/workingtree_4.py", line 226, in commit
    result = WorkingTree3.commit(self, message, revprops, *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/mutabletree.py", line 228, in commit
    *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commit.py", line 308, in commit
    self._check_bound_branch(possible_master_transports)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commit.py", line 449, in _check_bound_branch
    possible_master_transports)
  File "/usr/lib/python2.6/dist-packages/bzrlib/decorators.py", line 138, in read_locked
    result = unbound(self, *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/branch.py", line 2280, in get_master_branch
    possible_transports=possible_transports)
  File "/usr/lib/python2.6/dist-packages/bzrlib/branch.py", line 134, in open
    possible_transports=possible_transports)
  File "/usr/lib/python2.6/dist-packages/bzrlib/bzrdir.py", line 807, in open
    return BzrDir.open_from_transport(t, _unsupported=_unsupported)
  File "/usr/lib/python2.6/dist-packages/bzrlib/bzrdir.py", line 842, in open_from_transport
    return format.open(transport, _found=True)
  File "/usr/lib/python2.6/dist-packages/bzrlib/bzrdir.py", line 1918, in open
    return self._open(transport)
  File "/usr/lib/python2.6/dist-packages/bzrlib/bzrdir.py", line 2890, in _open
    return remote.RemoteBzrDir(transport, self)
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 111, in __init__
    response = self._call('BzrDir.open', path)
  File "/usr/lib/python2.6/dist-packages/bzrlib/remote.py", line 55, in _call
    return self._client.call(method, *args)
  File "/usr/lib/python2.6/dist-packages/bzrlib/smart/client.py", line 129, in call
    result, protocol = self.call_expecting_body(method, *args)
  File "/usr/lib/python2.6/dist-packages/bzrlib/smart/client.py", line 142, in call_expecting_body
    method, ar...

[Tim Kersten (timkersten)]

Just noting that this bug is still present in version bzr 2.0.