syntax to reverse a revision is confusing

Bug #323095 reported by Stuart Langridge
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Medium
Unassigned

Bug Description

If I wrongly committed a revision to this branch and I'd like to undo that, I have to remember to specify "." on the end of my merge command.

For example, imagine that in r570 I bzr rm'd a folder, and now (some number of committed revisions later) I realise that I shouldn't have removed it. The logical thing to do would be "bzr merge -r 570..569", but this doesn't work; that unmerges the changes in r570 in the trunk (or whichever branch your current branch is derived from). What I need is "bzr merge -r 570..569 ." (note the terminal ".")

This confused me for some time!

While it's obviously necessary to be able to unmerge revisions from your parent branch, I suggest that unmerging revisions from your own branch is likely to be quite common, so perhaps a warning saying "you didn't specify a branch, so this uses trunk, not your current branch" or similar might be useful.

Bazaar (bzr) 1.10

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 323095] [NEW] Unmerging a wrongly-committed revision is confusing

On Fri, 2009-01-30 at 09:37 +0000, Stuart Langridge wrote:
> Public bug reported:
>
> If I wrongly committed a revision to this branch and I'd like to undo
> that, I have to remember to specify "." on the end of my merge command.
>
> For example, imagine that in r570 I bzr rm'd a folder, and now (some
> number of committed revisions later) I realise that I shouldn't have
> removed it. The logical thing to do would be "bzr merge -r 570..569",
> but this doesn't work; that unmerges the changes in r570 in the trunk
> (or whichever branch your current branch is derived from). What I need
> is "bzr merge -r 570..569 ." (note the terminal ".")
>
> This confused me for some time!
>
> While it's obviously necessary to be able to unmerge revisions from your
> parent branch, I suggest that unmerging revisions from your own branch
> is likely to be quite common, so perhaps a warning saying "you didn't
> specify a branch, so this uses trunk, not your current branch" or
> similar might be useful.

EYOUAREABITSTUPIDBUTITISEASYTOMISSTHEDOT :-)

It would be possible to make specifying the branch mandatory when
reverse merging. It's a rare enough operation anyway, and I imagine
using the remembered merge location is even rarer.

Thanks,

James

Revision history for this message
Christian Reis (kiko) wrote : Re: Unmerging a wrongly-committed revision is confusing

I have gotten this wrong a few times too, so I think it's worth changing the UI.

Martin Pool (mbp)
summary: - Unmerging a wrongly-committed revision is confusing
+ syntax to reverse a revision is confusing
Changed in bzr:
status: New → Confirmed
importance: Undecided → Medium
tags: added: confusing-ui merge ui
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.